perf probe: Delete an unnecessary check before the function call "strfilter__delete"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 4 Jul 2015 05:44:22 +0000 (07:44 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 6 Jul 2015 11:58:36 +0000 (08:58 -0300)
The strfilter__delete() function tests whether its argument is NULL and
then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: kernel-janitors@vger.kernel.org
Link: http://lkml.kernel.org/r/5597751A.5000506@users.sourceforge.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-probe.c

index 1272559..b81cec3 100644 (file)
@@ -297,8 +297,7 @@ static void cleanup_params(void)
                clear_perf_probe_event(params.events + i);
        line_range__clear(&params.line_range);
        free(params.target);
-       if (params.filter)
-               strfilter__delete(params.filter);
+       strfilter__delete(params.filter);
        memset(&params, 0, sizeof(params));
 }