ext4: remove redundant assignment to error

Variable error is set to zero but this value is never read as it's not
used later on, hence it is a redundant assignment and can be removed.

Cleans up the following clang-analyzer warning:

fs/ext4/ioctl.c:657:3: warning: Value stored to 'error' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/1619691409-83160-1-git-send-email-jiapeng.chong@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 31627f7..a96d672 100644 (file)
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -659,10 +659,9 @@ static int ext4_ioc_getfsmap(struct super_block *sb,
        info.gi_sb = sb;
        info.gi_data = arg;
        error = ext4_getfsmap(sb, &xhead, ext4_getfsmap_format, &info);
-       if (error == EXT4_QUERY_RANGE_ABORT) {
-               error = 0;
+       if (error == EXT4_QUERY_RANGE_ABORT)
                aborted = true;
-       } else if (error)
+       else if (error)
                return error;
 
        /* If we didn't abort, set the "last" flag in the last fmx */