bpf, mips64: remove obsolete exception handling from div/mod
authorDaniel Borkmann <daniel@iogearbox.net>
Fri, 26 Jan 2018 22:33:45 +0000 (23:33 +0100)
committerAlexei Starovoitov <ast@kernel.org>
Sat, 27 Jan 2018 00:42:06 +0000 (16:42 -0800)
Since we've changed div/mod exception handling for src_reg in
eBPF verifier itself, remove the leftovers from mips64 JIT.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: David Daney <david.daney@cavium.com>
Reviewed-by: David Daney <david.daney@cavium.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
arch/mips/net/ebpf_jit.c

index 4e34703..296f141 100644 (file)
@@ -860,11 +860,6 @@ static int build_one_insn(const struct bpf_insn *insn, struct jit_ctx *ctx,
                        break;
                case BPF_DIV:
                case BPF_MOD:
-                       b_off = b_imm(exit_idx, ctx);
-                       if (is_bad_offset(b_off))
-                               return -E2BIG;
-                       emit_instr(ctx, beq, src, MIPS_R_ZERO, b_off);
-                       emit_instr(ctx, movz, MIPS_R_V0, MIPS_R_ZERO, src);
                        emit_instr(ctx, ddivu, dst, src);
                        if (bpf_op == BPF_DIV)
                                emit_instr(ctx, mflo, dst);
@@ -943,11 +938,6 @@ static int build_one_insn(const struct bpf_insn *insn, struct jit_ctx *ctx,
                        break;
                case BPF_DIV:
                case BPF_MOD:
-                       b_off = b_imm(exit_idx, ctx);
-                       if (is_bad_offset(b_off))
-                               return -E2BIG;
-                       emit_instr(ctx, beq, src, MIPS_R_ZERO, b_off);
-                       emit_instr(ctx, movz, MIPS_R_V0, MIPS_R_ZERO, src);
                        emit_instr(ctx, divu, dst, src);
                        if (bpf_op == BPF_DIV)
                                emit_instr(ctx, mflo, dst);