Revert "Btrfs: fix scrub to repair raid6 corruption"
authorSasha Levin <Alexander.Levin@microsoft.com>
Fri, 15 Jun 2018 02:39:13 +0000 (02:39 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 26 Jun 2018 00:08:06 +0000 (08:08 +0800)
This reverts commit 186a6519dc94964a4c5c68fca482f20f71551f26.

This commit used an incorrect log message.

Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/raid56.c
fs/btrfs/volumes.c

index af6a776..d016d4a 100644 (file)
@@ -2161,21 +2161,11 @@ int raid56_parity_recover(struct btrfs_root *root, struct bio *bio,
        }
 
        /*
-        * Loop retry:
-        * for 'mirror == 2', reconstruct from all other stripes.
-        * for 'mirror_num > 2', select a stripe to fail on every retry.
+        * reconstruct from the q stripe if they are
+        * asking for mirror 3
         */
-       if (mirror_num > 2) {
-               /*
-                * 'mirror == 3' is to fail the p stripe and
-                * reconstruct from the q stripe.  'mirror > 3' is to
-                * fail a data stripe and reconstruct from p+q stripe.
-                */
-               rbio->failb = rbio->real_stripes - (mirror_num - 1);
-               ASSERT(rbio->failb > 0);
-               if (rbio->failb <= rbio->faila)
-                       rbio->failb--;
-       }
+       if (mirror_num == 3)
+               rbio->failb = rbio->real_stripes - 2;
 
        ret = lock_stripe_add(rbio);
 
index 76017e1..c2495cd 100644 (file)
@@ -5186,14 +5186,7 @@ int btrfs_num_copies(struct btrfs_fs_info *fs_info, u64 logical, u64 len)
        else if (map->type & BTRFS_BLOCK_GROUP_RAID5)
                ret = 2;
        else if (map->type & BTRFS_BLOCK_GROUP_RAID6)
-               /*
-                * There could be two corrupted data stripes, we need
-                * to loop retry in order to rebuild the correct data.
-                *
-                * Fail a stripe at a time on every retry except the
-                * stripe under reconstruction.
-                */
-               ret = map->num_stripes;
+               ret = 3;
        else
                ret = 1;
        free_extent_map(em);