zink: don't use defunct custom-flag
authorErik Faye-Lund <erik.faye-lund@collabora.com>
Tue, 6 Dec 2022 15:16:08 +0000 (16:16 +0100)
committerEric Engestrom <eric@engestrom.ch>
Wed, 14 Dec 2022 20:47:01 +0000 (20:47 +0000)
We're no longer respecting this flag, so there's no need in setting it.

Fixes: 00dc0036bb6 ("zink: flatten out buffer creation usage flags codepath")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20183>
(cherry picked from commit 2ccf481c17ccded161b9eecb63a257d81056e3ec)

.pick_status.json
src/gallium/drivers/zink/zink_context.c

index 881bd68..b9ab3ff 100644 (file)
         "description": "zink: don't use defunct custom-flag",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "main_sha": null,
         "because_sha": "00dc0036bb6d0c6de1ec3dc395e1d9e63d05ed83"
     },
index 57da750..650717c 100644 (file)
@@ -3958,11 +3958,7 @@ zink_create_stream_output_target(struct pipe_context *pctx,
    if (!t)
       return NULL;
 
-   /* using PIPE_BIND_CUSTOM here lets us create a custom pipe buffer resource,
-    * which allows us to differentiate and use VK_BUFFER_USAGE_TRANSFORM_FEEDBACK_COUNTER_BUFFER_BIT_EXT
-    * as we must for this case
-    */
-   t->counter_buffer = pipe_buffer_create(pctx->screen, PIPE_BIND_STREAM_OUTPUT | PIPE_BIND_CUSTOM, PIPE_USAGE_DEFAULT, 4);
+   t->counter_buffer = pipe_buffer_create(pctx->screen, PIPE_BIND_STREAM_OUTPUT, PIPE_USAGE_DEFAULT, 4);
    if (!t->counter_buffer) {
       FREE(t);
       return NULL;