Use QStringList::join(QChar) overload where applicable [QtNetwork]

This is an automated change performing the following replacements:
                    join\("(.)"\) -> join('\1')
  join\(QLatin1String\("(.)"\)\)  -> join(QLatin1Char('\1'))
  join\(QStringLiteral\("(.)"\)\) -> join(QLatin1Char('\1'))

Change-Id: I5b75877ba192fa1357e67fee70dff7c0475991e8
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>

diff --git a/src/network/kernel/qnetworkproxy.cpp b/src/network/kernel/qnetworkproxy.cpp
index e26374e..181ea51 100644 (file)
--- a/src/network/kernel/qnetworkproxy.cpp
+++ b/src/network/kernel/qnetworkproxy.cpp
@@ -1610,7 +1610,7 @@ QDebug operator<<(QDebug debug, const QNetworkProxy &proxy)
         scaps << QStringLiteral("Caching");
     if (caps & QNetworkProxy::HostNameLookupCapability)
         scaps << QStringLiteral("NameLookup");
-    debug << "[" << scaps.join(QStringLiteral(" ")) << "]";
+    debug << "[" << scaps.join(QLatin1Char(' ')) << "]";
     return debug;
 }
 #endif

diff --git a/tests/auto/network/kernel/qdnslookup/tst_qdnslookup.cpp b/tests/auto/network/kernel/qdnslookup/tst_qdnslookup.cpp
index 0afdd56..c80f2a8 100644 (file)
--- a/tests/auto/network/kernel/qdnslookup/tst_qdnslookup.cpp
+++ b/tests/auto/network/kernel/qdnslookup/tst_qdnslookup.cpp
@@ -168,7 +168,7 @@ void tst_QDnsLookup::lookup()
             addresses << record.value().toString().toLower();
     }
     addresses.sort();
-    QCOMPARE(addresses.join(" "), host);
+    QCOMPARE(addresses.join(' '), host);
 
     // mail exchanges
     QStringList mailExchanges;
@@ -176,7 +176,7 @@ void tst_QDnsLookup::lookup()
         QCOMPARE(record.name(), domain);
         mailExchanges << QString("%1 %2").arg(QString::number(record.preference()), record.exchange());
     }
-    QCOMPARE(mailExchanges.join(" "), mx);
+    QCOMPARE(mailExchanges.join(' '), mx);
 
     // name servers
     QStringList nameServers;
@@ -186,7 +186,7 @@ void tst_QDnsLookup::lookup()
             nameServers << record.value();
     }
     nameServers.sort();
-    QCOMPARE(nameServers.join(" "), ns);
+    QCOMPARE(nameServers.join(' '), ns);
 
     // pointers
     if (!ptr.isEmpty()) {
@@ -208,7 +208,7 @@ void tst_QDnsLookup::lookup()
                 QString::number(record.port()),
                 record.target());
     }
-    QCOMPARE(services.join(" "), srv);
+    QCOMPARE(services.join(' '), srv);
 
     // text
     if (!txt.isEmpty()) {

diff --git a/tests/auto/network/kernel/qhostinfo/tst_qhostinfo.cpp b/tests/auto/network/kernel/qhostinfo/tst_qhostinfo.cpp
index 5285425..a733385 100644 (file)
--- a/tests/auto/network/kernel/qhostinfo/tst_qhostinfo.cpp
+++ b/tests/auto/network/kernel/qhostinfo/tst_qhostinfo.cpp
@@ -302,7 +302,7 @@ void tst_QHostInfo::lookupIPv4()
     QStringList expected = addresses.split(' ');
     expected.sort();
 
-    QCOMPARE(tmp.join(" "), expected.join(" "));
+    QCOMPARE(tmp.join(' '), expected.join(' '));
 }
 
 void tst_QHostInfo::lookupIPv6_data()
@@ -349,7 +349,7 @@ void tst_QHostInfo::lookupIPv6()
     QStringList expected = addresses.split(' ');
     expected.sort();
 
-    QCOMPARE(tmp.join(" ").toLower(), expected.join(" ").toLower());
+    QCOMPARE(tmp.join(' ').toLower(), expected.join(' ').toLower());
 }
 
 void tst_QHostInfo::reverseLookup_data()
@@ -414,7 +414,7 @@ void tst_QHostInfo::blockingLookup()
     QStringList expected = addresses.split(' ');
     expected.sort();
 
-    QCOMPARE(tmp.join(" ").toUpper(), expected.join(" ").toUpper());
+    QCOMPARE(tmp.join(' ').toUpper(), expected.join(' ').toUpper());
 }
 
 void tst_QHostInfo::raceCondition()