drm/amdgpu: Fix the incomplete product number
authorRoy Sun <Roy.Sun@amd.com>
Wed, 20 Jul 2022 08:19:50 +0000 (16:19 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 28 Jul 2022 20:05:14 +0000 (16:05 -0400)
The comments say that the product number is a 16-digit HEX string so the
buffer needs to be at least 17 characters to hold the NUL terminator. Expand
the buffer size to 20 to avoid the alignment issues.

The comment:Product number should only be 16 characters. Any
more,and something could be wrong. Cap it at 16 to be safe

Signed-off-by: Roy Sun <Roy.Sun@amd.com>
Reviewed-by: André Almeida <andrealmeid@igalia.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu.h

index b075845a53287dc5af0eb5b4f7b983b2f95f17da..e146810c700ba7846c926ef205f6480418b3f415 100644 (file)
@@ -1020,7 +1020,7 @@ struct amdgpu_device {
        bool                            psp_sysfs_en;
 
        /* Chip product information */
-       char                            product_number[16];
+       char                            product_number[20];
        char                            product_name[AMDGPU_PRODUCT_NAME_LEN];
        char                            serial[20];