Partially revert "[CMake] Fix building with -DBUILD_SHARED_LIBS=ON on mingw"
authorMartin Storsjö <martin@martin.st>
Tue, 12 May 2020 05:20:34 +0000 (08:20 +0300)
committerMartin Storsjö <martin@martin.st>
Tue, 12 May 2020 05:20:44 +0000 (08:20 +0300)
This reverts parts of commit 609ef948387ba40e3693c2bd693d82ca34dcdc02,
as it caused build failures on windows if LLVM_BUILD_EXAMPLES was
enabled, due to Bye being added as a dependency of the lit tests.

llvm/examples/Bye/CMakeLists.txt

index 362086e..3206f90 100644 (file)
@@ -2,18 +2,12 @@ if(LLVM_BYE_LINK_INTO_TOOLS)
   message(WARNING "Setting LLVM_BYE_LINK_INTO_TOOLS=ON only makes sense for testing purpose")
 endif()
 
-# The plugin expects to not link against the Support and Core libraries,
-# but expects them to exist in the process loading the plugin. This doesn't
-# work with DLLs on Windows (where a shared library can't have undefined
-# references), so just skip this testcase on Windows.
-if (NOT WIN32)
-  add_llvm_pass_plugin(Bye
-    Bye.cpp
-    DEPENDS
-    intrinsics_gen
-    BUILDTREE_ONLY
-   )
+add_llvm_pass_plugin(Bye
+  Bye.cpp
+  DEPENDS
+  intrinsics_gen
+  BUILDTREE_ONLY
+ )
 
-  install(TARGETS ${name} RUNTIME DESTINATION examples)
-  set_target_properties(${name} PROPERTIES FOLDER "Examples")
-endif()
+install(TARGETS ${name} RUNTIME DESTINATION examples)
+set_target_properties(${name} PROPERTIES FOLDER "Examples")