target: Remove hack to make READ CAPACITY(10) lie if thin provisioning is enabled
authorRoland Dreier <roland@purestorage.com>
Wed, 14 Mar 2012 17:12:03 +0000 (10:12 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 16 Mar 2012 02:14:48 +0000 (19:14 -0700)
Remove the hack that has READ CAPACITY(10) return 0xFFFFFFFF as the
number of sectors when thin provisioning is enabled.  This is supposed
to trigger the initiator to use READ CAPACITY(16) in this case so that
it finds out about thin provisioning.  But an initiator that cares about
thin provisioning is going to ask anyway, and an initiator that doesn't
know about READ CAPACITY(16) is going to get the wrong capacity.  So
just have READ CAPACITY(10) return the size it's supposed to.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_cdb.c

index 41ca2d4..30a6770 100644 (file)
@@ -694,11 +694,6 @@ int target_emulate_readcapacity(struct se_task *task)
        buf[5] = (dev->se_sub_dev->se_dev_attrib.block_size >> 16) & 0xff;
        buf[6] = (dev->se_sub_dev->se_dev_attrib.block_size >> 8) & 0xff;
        buf[7] = dev->se_sub_dev->se_dev_attrib.block_size & 0xff;
-       /*
-        * Set max 32-bit blocks to signal SERVICE ACTION READ_CAPACITY_16
-       */
-       if (dev->se_sub_dev->se_dev_attrib.emulate_tpu || dev->se_sub_dev->se_dev_attrib.emulate_tpws)
-               put_unaligned_be32(0xFFFFFFFF, &buf[0]);
 
        transport_kunmap_data_sg(cmd);