remoteproc: st: Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:47:35 +0000 (08:47 -0600)
committerBjorn Andersson <andersson@kernel.org>
Wed, 19 Apr 2023 01:56:51 +0000 (18:56 -0700)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230310144736.1546972-1-robh@kernel.org
drivers/remoteproc/st_remoteproc.c

index e6bd3c7..3f1b896 100644 (file)
@@ -382,7 +382,7 @@ static int st_rproc_probe(struct platform_device *pdev)
                clk_set_rate(ddata->clk, ddata->clk_rate);
        }
 
-       if (of_get_property(np, "mbox-names", NULL)) {
+       if (of_property_present(np, "mbox-names")) {
                ddata->mbox_client_vq0.dev              = dev;
                ddata->mbox_client_vq0.tx_done          = NULL;
                ddata->mbox_client_vq0.tx_block = false;