staging: gdm724x: kzalloc should be used instead of kmalloc/memset
authorTeodora Baluta <teobaluta@gmail.com>
Tue, 22 Oct 2013 22:15:26 +0000 (01:15 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Oct 2013 03:34:46 +0000 (20:34 -0700)
This patch fixes the following coccinelle warnings in driver gdm724x:

drivers/staging/gdm724x/gdm_usb.c:127:9-16: WARNING: kzalloc should be used for t_sdu, instead of kmalloc/memset
drivers/staging/gdm724x/gdm_usb.c:91:5-12: WARNING: kzalloc should be used for t, instead of kmalloc/memset

Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gdm724x/gdm_usb.c

index bdc9637..781134a 100644 (file)
@@ -88,12 +88,11 @@ static struct usb_tx *alloc_tx_struct(int len)
        struct usb_tx *t = NULL;
        int ret = 0;
 
-       t = kmalloc(sizeof(struct usb_tx), GFP_ATOMIC);
+       t = kzalloc(sizeof(struct usb_tx), GFP_ATOMIC);
        if (!t) {
                ret = -ENOMEM;
                goto out;
        }
-       memset(t, 0, sizeof(struct usb_tx));
 
        t->urb = usb_alloc_urb(0, GFP_ATOMIC);
        if (!(len % 512))
@@ -124,12 +123,11 @@ static struct usb_tx_sdu *alloc_tx_sdu_struct(void)
        int ret = 0;
 
 
-       t_sdu = kmalloc(sizeof(struct usb_tx_sdu), GFP_ATOMIC);
+       t_sdu = kzalloc(sizeof(struct usb_tx_sdu), GFP_ATOMIC);
        if (!t_sdu) {
                ret = -ENOMEM;
                goto out;
        }
-       memset(t_sdu, 0, sizeof(struct usb_tx_sdu));
 
        t_sdu->buf = kmalloc(SDU_BUF_SIZE, GFP_ATOMIC);
        if (!t_sdu->buf) {