[NextBrowser][DF240927-01200] setting dfault image if favicon data is missing. 04/318604/5 submit/tizen/20241004.160014
authorshahnawaz.a <shahnawaz.a@samsung.com>
Thu, 3 Oct 2024 07:22:56 +0000 (12:52 +0530)
committerShahnawaz Ahmad <shahnawaz.a@samsung.com>
Fri, 4 Oct 2024 09:46:26 +0000 (09:46 +0000)
Change-Id: I760870b972cc71507ba52bfc383d4f74e05049e3
Signed-off-by: shahnawaz.a <shahnawaz.a@samsung.com>
chrome/browser/resources/samsung/samsung_featured_app.html
chrome/browser/resources/samsung/samsung_featured_app.ts
chrome/browser/resources/samsung/samsung_opentabs_app.html
chrome/browser/resources/samsung/samsung_opentabs_app.js

index 080611e672d34dacf4bb69519fc5f81e1c0dd22b..a106c18ba29c87164eaf8857f40489db06b5d561 100644 (file)
@@ -27,7 +27,7 @@
                     <img src = "[[item.imgSrc]]" alt = "[[item.title]]">
                   </div>
                   <div class="itemFavicon" style="background-image: [[item.favicon]]">
-                    <img src = "[[item.favicon]]" alt = "[[item.title]]">
+                    <img src = "[[item.favicon]]" alt = " " on-error = "onErroInImageLoad_">
                   </div>
                   <div class="marquee itemName description" aria-hidden="true" aria-label="[[item.title]], item [[item.itemNum]] of [[item.total]]">
                     [[item.title]]
index a9232c56bb8395ffc904ba6e1607bad21aa694e6..27379ed81750c571e64786a738601369965bce8d 100644 (file)
@@ -117,7 +117,10 @@ export class SamsungFeaturedAppElement extends PolymerElement {
     }
 
   }
-
+  onErroInImageLoad_(event:any){
+    const img = event.target;
+    img.src = "chrome://resources/images/samsung/wb_logo_web_32.png";
+  }
   public OnClicked() : void {
     console.log('Invoked');
   }
index a3296746ad2875b2c1102702928a06a5141ba89d..bb81eec09803e7bcfae3fb95e3d5b32b3f01f6cb 100644 (file)
@@ -37,7 +37,7 @@
                   <a class="bookmarkThumbnailLink" href="[[item.url]]" aria-label="[[item.title]]" type="" target="">
                     <div class="bookmarkItemFavicon">
                         <div class="itemFaviconOpenTabs" >
-                          <img src = "data:image/png;base64,[[item.favicon_data]]" alt = " " >
+                          <img src = "[[item.favicon_data]]" alt = " " on-error = "onErroInImageLoad_">
                         </div>
                     </div>
                     <div class="marquee bookmarkItemName description" aria-label="[[item.title]]">
index 37f1491286eac52599d83a820cd7785d5885ca1c..929b013eeacf4068ba5990c0acfa69c8380fc86d 100644 (file)
@@ -53,7 +53,6 @@ export class SOpenTabsElement extends PolymerElement {
     }).catch((error) => {
         console.log(error);
     });
-    
     addWebUiListener(
       'high-contrast-changed' , (value) =>{
         console.log(value);
@@ -80,7 +79,7 @@ onthumbnailOptionsChanged_(){
                     let sp ={
                         'title' : data[deviceID][j].title,
                         'url' :  data[deviceID][j].url,
-                        'favicon_data': data[deviceID][j].favicon_data
+                        'favicon_data': data[deviceID][j].favicon_data == ""? "chrome://resources/images/samsung/wb_logo_web_32.png" : "data:image/png;base64,"+data[deviceID][j].favicon_data,
                     }
                     subItem.push(sp);
                 }
@@ -106,6 +105,7 @@ onthumbnailOptionsChanged_(){
         buttonWarpper.classList.remove('highContrast');
     }
   }
+
   onDeleteAllClicked_(event){
     console.log('onDeleteAllClicked_');
     this.deviceIdToBeRemoved = "";
@@ -146,6 +146,10 @@ onthumbnailOptionsChanged_(){
         cancelButtonNode.style.marginRight = '10px';
        }
   }
+  onErroInImageLoad_(event){
+    const img = event.target;
+    img.src = "chrome://resources/images/samsung/wb_logo_web_32.png";
+  }
   onDialogConfirmClick_() {
     console.log('onDialogConfirmClick_');
     changeIsPopUpOpened("false");