Add tag format check
authorZhang Qiang <qiang.z.zhang@intel.com>
Mon, 28 Jan 2013 16:41:12 +0000 (11:41 -0500)
committerZhang Qiang <qiang.z.zhang@intel.com>
Mon, 28 Jan 2013 19:42:08 +0000 (14:42 -0500)
Currently, valid tag format is: submit/$target/$date.$time

Change-Id: Ie209565c1dc20bdc9e27a46579da5dbc902432f9

gitbuildsys/cmd_submit.py

index 181e4f1..5e466e4 100644 (file)
@@ -19,6 +19,7 @@
 """Implementation of subcmd: submit"""
 
 import os
+import re
 import time
 
 from gitbuildsys.utils import edit
@@ -77,6 +78,11 @@ def main(args):
 
     if args.tag:
         tagname = args.tag
+        tag_re = re.compile(r'^submit/\S+/\d{8}\.\d{6}$')
+        if not tag_re.match(tagname):
+            raise GbsError("invalid tag %s, valid tag format is "
+                           "submit/$target/$date.$time. For example:\n      "
+                           "submit/trunk/20130128.022439 " % tagname)
     else:
         target = args.target
         if not target: