regulator: remove redundant ret variable
authorMinghao Chi <chi.minghao@zte.com.cn>
Tue, 4 Jan 2022 10:41:39 +0000 (10:41 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 4 Jan 2022 15:00:39 +0000 (15:00 +0000)
Return value from regmap_update_bits() directly instead
of taking this in another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
Link: https://lore.kernel.org/r/20220104104139.601031-1-chi.minghao@zte.com.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/mt6380-regulator.c

index 9efd871..2e6b61d 100644 (file)
@@ -183,7 +183,7 @@ static const unsigned int ldo_volt_table4[] = {
 static int mt6380_regulator_set_mode(struct regulator_dev *rdev,
                                     unsigned int mode)
 {
-       int ret, val = 0;
+       int val = 0;
        struct mt6380_regulator_info *info = rdev_get_drvdata(rdev);
 
        switch (mode) {
@@ -199,10 +199,8 @@ static int mt6380_regulator_set_mode(struct regulator_dev *rdev,
 
        val <<= ffs(info->modeset_mask) - 1;
 
-       ret = regmap_update_bits(rdev->regmap, info->modeset_reg,
+       return regmap_update_bits(rdev->regmap, info->modeset_reg,
                                 info->modeset_mask, val);
-
-       return ret;
 }
 
 static unsigned int mt6380_regulator_get_mode(struct regulator_dev *rdev)