net: phy: at803x: fix error return code in at803x_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 18 Nov 2022 10:36:35 +0000 (10:36 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 22 Nov 2022 04:43:01 +0000 (20:43 -0800)
Fix to return a negative error code from the ccr read error handling
case instead of 0, as done elsewhere in this function.

Fixes: 3265f4218878 ("net: phy: at803x: add fiber support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20221118103635.254256-1-weiyongjun@huaweicloud.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/at803x.c

index 349b7b1..d499659 100644 (file)
@@ -870,8 +870,10 @@ static int at803x_probe(struct phy_device *phydev)
                        .wolopts = 0,
                };
 
-               if (ccr < 0)
+               if (ccr < 0) {
+                       ret = ccr;
                        goto err;
+               }
                mode_cfg = ccr & AT803X_MODE_CFG_MASK;
 
                switch (mode_cfg) {