mtd: rawnand: ingenic: remove redundant get_device() in ingenic_ecc_get()
authorYu Kuai <yukuai3@huawei.com>
Sat, 31 Oct 2020 10:54:39 +0000 (18:54 +0800)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 10 Dec 2020 21:37:31 +0000 (22:37 +0100)
of_find_device_by_node() already takes a reference to the device, and
ingenic_ecc_release() will drop the reference. So, the get_device() in
ingenic_ecc_get() is redundand.

Fixes: 15de8c6efd0e("mtd: rawnand: ingenic: Separate top-level and SoC specific code")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Acked-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20201031105439.2304211-1-yukuai3@huawei.com
drivers/mtd/nand/raw/ingenic/ingenic_ecc.c

index 8e22cd6..efe0ffe 100644 (file)
@@ -71,8 +71,6 @@ static struct ingenic_ecc *ingenic_ecc_get(struct device_node *np)
        if (!pdev || !platform_get_drvdata(pdev))
                return ERR_PTR(-EPROBE_DEFER);
 
-       get_device(&pdev->dev);
-
        ecc = platform_get_drvdata(pdev);
        clk_prepare_enable(ecc->clk);