objtool: Remove redundant .rodata section name comparison
authorMuchun Song <songmuchun@bytedance.com>
Sun, 12 Apr 2020 14:44:05 +0000 (22:44 +0800)
committerIngo Molnar <mingo@kernel.org>
Wed, 22 Apr 2020 08:53:50 +0000 (10:53 +0200)
If the prefix of section name is not '.rodata', the following
function call can never return 0.

    strcmp(sec->name, C_JUMP_TABLE_SECTION)

So the name comparison is pointless, just remove it.

Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
tools/objtool/check.c

index cffa5e3..e06a891 100644 (file)
@@ -1354,8 +1354,8 @@ static void mark_rodata(struct objtool_file *file)
         * .rodata.str1.* sections are ignored; they don't contain jump tables.
         */
        for_each_sec(file, sec) {
-               if ((!strncmp(sec->name, ".rodata", 7) && !strstr(sec->name, ".str1.")) ||
-                   !strcmp(sec->name, C_JUMP_TABLE_SECTION)) {
+               if (!strncmp(sec->name, ".rodata", 7) &&
+                   !strstr(sec->name, ".str1.")) {
                        sec->rodata = true;
                        found = true;
                }