ieee802154: Change error code on monitor scan netlink request
authorMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 14 Feb 2023 13:50:32 +0000 (14:50 +0100)
committerStefan Schmidt <stefan@datenfreihafen.org>
Sat, 18 Feb 2023 15:41:23 +0000 (16:41 +0100)
Returning EPERM gives the impression that "right now" it is not
possible, but "later" it could be, while what we want to express is the
fact that this is not currently supported at all (might change in the
future). So let's return EOPNOTSUPP instead.

Fixes: ed3557c947e1 ("ieee802154: Add support for user scanning requests")
Suggested-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20230214135035.1202471-4-miquel.raynal@bootlin.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
net/ieee802154/nl802154.c

index 12ca84e..f4a5070 100644 (file)
@@ -1409,7 +1409,7 @@ static int nl802154_trigger_scan(struct sk_buff *skb, struct genl_info *info)
 
        if (wpan_dev->iftype == NL802154_IFTYPE_MONITOR) {
                NL_SET_ERR_MSG(info->extack, "Monitors are not allowed to perform scans");
-               return -EPERM;
+               return -EOPNOTSUPP;
        }
 
        if (!nla_get_u8(info->attrs[NL802154_ATTR_SCAN_TYPE])) {