PCI: Simplify pci_dev_driver()
authorBjorn Helgaas <bhelgaas@google.com>
Tue, 6 Oct 2020 21:49:17 +0000 (16:49 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 25 Aug 2023 13:15:29 +0000 (08:15 -0500)
Simplify pci_dev_driver() by removing the "else".  The "if" case always
returns, so the "else" is superfluous.  No functional change intended.

Link: https://lore.kernel.org/r/20230824193712.542167-9-helgaas@kernel.org
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/pci/pci-driver.c

index a44ecf6..a79c110 100644 (file)
@@ -1474,14 +1474,15 @@ static struct pci_driver pci_compat_driver = {
  */
 struct pci_driver *pci_dev_driver(const struct pci_dev *dev)
 {
+       int i;
+
        if (dev->driver)
                return dev->driver;
-       else {
-               int i;
-               for (i = 0; i <= PCI_ROM_RESOURCE; i++)
-                       if (dev->resource[i].flags & IORESOURCE_BUSY)
-                               return &pci_compat_driver;
-       }
+
+       for (i = 0; i <= PCI_ROM_RESOURCE; i++)
+               if (dev->resource[i].flags & IORESOURCE_BUSY)
+                       return &pci_compat_driver;
+
        return NULL;
 }
 EXPORT_SYMBOL(pci_dev_driver);