[Merge] change code to compare timestamp
authorJaeyun <jy1210.jung@samsung.com>
Tue, 30 Oct 2018 09:43:51 +0000 (18:43 +0900)
committerJijoong Moon <jijoong.moon@samsung.com>
Wed, 31 Oct 2018 02:19:28 +0000 (11:19 +0900)
to fix coverity issue, use GST_CLOCK_DIFF to get time-diff of buffer pts time.
(pts is unsigned value, diff of two buffer timestamp always returns unsigned value)

Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
gst/tensor_merge/gsttensormerge.c

index 47e9924..6e7ce06 100644 (file)
@@ -514,9 +514,11 @@ gst_tensor_merge_collect_buffer (GstTensorMerge * tensor_merge,
         return FALSE;
       }
 
-      if (pad->buffer != NULL
-          && ABS (tensor_merge->current_time - GST_BUFFER_PTS (pad->buffer)) <
-          ABS (tensor_merge->current_time - GST_BUFFER_PTS (buf))) {
+      if (pad->buffer != NULL &&
+          ABS (GST_CLOCK_DIFF (tensor_merge->current_time,
+                  GST_BUFFER_PTS (pad->buffer))) <
+          ABS (GST_CLOCK_DIFF (tensor_merge->current_time,
+                  GST_BUFFER_PTS (buf)))) {
         gst_buffer_unref (buf);
         buf = pad->buffer;
       } else {