v4l2src: add a comment about a "hidden" assumption on rank values
authorVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Fri, 2 Dec 2011 12:01:22 +0000 (12:01 +0000)
committerVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Fri, 2 Dec 2011 14:44:47 +0000 (14:44 +0000)
https://bugzilla.gnome.org/show_bug.cgi?id=665387

sys/v4l2/gstv4l2object.c

index 76ac677..f191bc9 100644 (file)
@@ -893,6 +893,8 @@ gst_v4l2_object_get_format_from_fourcc (GstV4l2Object * v4l2object,
 
 
 /* complete made up ranking, the values themselves are meaningless */
+/* These ranks MUST be X such that X<<15 fits on a signed int - see
+   the comment at the end of gst_v4l2_object_format_get_rank. */
 #define YUV_BASE_RANK     1000
 #define JPEG_BASE_RANK     500
 #define DV_BASE_RANK       200