scsi: hisi_sas: Modify the commit information for DSM method
authorLuo Jiaxing <luojiaxing@huawei.com>
Fri, 15 May 2020 14:13:43 +0000 (22:13 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 20 May 2020 01:23:58 +0000 (21:23 -0400)
Make it clear that BIOS may modify some register settings.

Link: https://lore.kernel.org/r/1589552025-165012-3-git-send-email-john.garry@huawei.com
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

index 59b1421..edab838 100644 (file)
@@ -912,11 +912,15 @@ static int hw_init_v3_hw(struct hisi_hba *hisi_hba)
                return -EINVAL;
        }
 
-       /* Switch over to MSI handling , from PCI AER default */
+       /*
+        * This DSM handles some hardware-related configurations:
+        * 1. Switch over to MSI error handling in kernel
+        * 2. BIOS *may* reset some register values through this method
+        */
        obj = acpi_evaluate_dsm(ACPI_HANDLE(dev), &guid, 0,
                                DSM_FUNC_ERR_HANDLE_MSI, NULL);
        if (!obj)
-               dev_warn(dev, "Switch over to MSI handling failed\n");
+               dev_warn(dev, "can not find DSM method, ignore\n");
        else
                ACPI_FREE(obj);