drm/i915/uc: Add message with firmware url
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Mon, 16 Oct 2017 14:47:19 +0000 (14:47 +0000)
committerJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Mon, 16 Oct 2017 15:53:28 +0000 (18:53 +0300)
In case of firmware fetch failure we should help user
find latest firmware. URL macro duplication from csr.c
will be fixed in upcoming patch.

Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171016144724.17244-11-michal.wajdeczko@intel.com
drivers/gpu/drm/i915/intel_uc_fw.c
drivers/gpu/drm/i915/intel_uc_fw.h

index 8a06781..1bb0319 100644 (file)
@@ -188,6 +188,8 @@ fail:
 
        DRM_WARN("%s: Failed to fetch firmware %s (error %d)\n",
                 intel_uc_fw_type_repr(uc_fw->type), uc_fw->path, err);
+       DRM_INFO("%s: Firmware can be downloaded from %s\n",
+                intel_uc_fw_type_repr(uc_fw->type), INTEL_UC_FIRMWARE_URL);
 
        release_firmware(fw);           /* OK even if fw is NULL */
 }
index 5c01849..1d580fa 100644 (file)
@@ -27,6 +27,8 @@
 
 struct drm_i915_private;
 
+#define INTEL_UC_FIRMWARE_URL "https://01.org/linuxgraphics/downloads/firmware"
+
 enum intel_uc_fw_status {
        INTEL_UC_FIRMWARE_FAIL = -1,
        INTEL_UC_FIRMWARE_NONE = 0,