platform/surface: dtx: Use target-ID enum instead of hard-coding values
authorMaximilian Luz <luzmaximilian@gmail.com>
Fri, 2 Dec 2022 22:33:24 +0000 (23:33 +0100)
committerHans de Goede <hdegoede@redhat.com>
Thu, 2 Feb 2023 21:48:20 +0000 (22:48 +0100)
Instead of hard-coding the target ID, use the respective enum
ssam_ssh_tid value.

Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20221202223327.690880-7-luzmaximilian@gmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/surface/surface_dtx.c

index ed36944..0de76a7 100644 (file)
@@ -71,63 +71,63 @@ static_assert(sizeof(struct ssam_bas_base_info) == 2);
 
 SSAM_DEFINE_SYNC_REQUEST_N(ssam_bas_latch_lock, {
        .target_category = SSAM_SSH_TC_BAS,
-       .target_id       = 0x01,
+       .target_id       = SSAM_SSH_TID_SAM,
        .command_id      = 0x06,
        .instance_id     = 0x00,
 });
 
 SSAM_DEFINE_SYNC_REQUEST_N(ssam_bas_latch_unlock, {
        .target_category = SSAM_SSH_TC_BAS,
-       .target_id       = 0x01,
+       .target_id       = SSAM_SSH_TID_SAM,
        .command_id      = 0x07,
        .instance_id     = 0x00,
 });
 
 SSAM_DEFINE_SYNC_REQUEST_N(ssam_bas_latch_request, {
        .target_category = SSAM_SSH_TC_BAS,
-       .target_id       = 0x01,
+       .target_id       = SSAM_SSH_TID_SAM,
        .command_id      = 0x08,
        .instance_id     = 0x00,
 });
 
 SSAM_DEFINE_SYNC_REQUEST_N(ssam_bas_latch_confirm, {
        .target_category = SSAM_SSH_TC_BAS,
-       .target_id       = 0x01,
+       .target_id       = SSAM_SSH_TID_SAM,
        .command_id      = 0x09,
        .instance_id     = 0x00,
 });
 
 SSAM_DEFINE_SYNC_REQUEST_N(ssam_bas_latch_heartbeat, {
        .target_category = SSAM_SSH_TC_BAS,
-       .target_id       = 0x01,
+       .target_id       = SSAM_SSH_TID_SAM,
        .command_id      = 0x0a,
        .instance_id     = 0x00,
 });
 
 SSAM_DEFINE_SYNC_REQUEST_N(ssam_bas_latch_cancel, {
        .target_category = SSAM_SSH_TC_BAS,
-       .target_id       = 0x01,
+       .target_id       = SSAM_SSH_TID_SAM,
        .command_id      = 0x0b,
        .instance_id     = 0x00,
 });
 
 SSAM_DEFINE_SYNC_REQUEST_R(ssam_bas_get_base, struct ssam_bas_base_info, {
        .target_category = SSAM_SSH_TC_BAS,
-       .target_id       = 0x01,
+       .target_id       = SSAM_SSH_TID_SAM,
        .command_id      = 0x0c,
        .instance_id     = 0x00,
 });
 
 SSAM_DEFINE_SYNC_REQUEST_R(ssam_bas_get_device_mode, u8, {
        .target_category = SSAM_SSH_TC_BAS,
-       .target_id       = 0x01,
+       .target_id       = SSAM_SSH_TID_SAM,
        .command_id      = 0x0d,
        .instance_id     = 0x00,
 });
 
 SSAM_DEFINE_SYNC_REQUEST_R(ssam_bas_get_latch_status, u8, {
        .target_category = SSAM_SSH_TC_BAS,
-       .target_id       = 0x01,
+       .target_id       = SSAM_SSH_TID_SAM,
        .command_id      = 0x11,
        .instance_id     = 0x00,
 });