projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2e4806d
)
clk: si5341: fix an error code problem in si5341_output_clk_set_rate
author
Su Hui
<suhui@nfschina.com>
Wed, 1 Nov 2023 03:16:36 +0000
(11:16 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Thu, 25 Jan 2024 23:35:38 +0000
(15:35 -0800)
[ Upstream commit
5607068ae5ab02c3ac9cabc6859d36e98004c341
]
regmap_bulk_write() return zero or negative error code, return the value
of regmap_bulk_write() rather than '0'.
Fixes:
3044a860fd09
("clk: Add Si5341/Si5340 driver")
Acked-by: Mike Looijmans <mike.looijmans@topic.nl>
Signed-off-by: Su Hui <suhui@nfschina.com>
Link:
https://lore.kernel.org/r/20231101031633.996124-1-suhui@nfschina.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/clk-si5341.c
patch
|
blob
|
history
diff --git
a/drivers/clk/clk-si5341.c
b/drivers/clk/clk-si5341.c
index
9599857
..
2920fe2
100644
(file)
--- a/
drivers/clk/clk-si5341.c
+++ b/
drivers/clk/clk-si5341.c
@@
-895,10
+895,8
@@
static int si5341_output_clk_set_rate(struct clk_hw *hw, unsigned long rate,
r[0] = r_div ? (r_div & 0xff) : 1;
r[1] = (r_div >> 8) & 0xff;
r[2] = (r_div >> 16) & 0xff;
-
err =
regmap_bulk_write(output->data->regmap,
+
return
regmap_bulk_write(output->data->regmap,
SI5341_OUT_R_REG(output), r, 3);
-
- return 0;
}
static int si5341_output_reparent(struct clk_si5341_output *output, u8 index)