clk: at91: Use kcalloc() in of_at91_clk_pll_get_characteristics()
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 19 Apr 2017 17:43:03 +0000 (19:43 +0200)
committerStephen Boyd <sboyd@codeaurora.org>
Sat, 22 Apr 2017 02:20:34 +0000 (19:20 -0700)
Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/at91/clk-pll.c

index 45ad168..7d3223f 100644 (file)
@@ -399,18 +399,18 @@ of_at91_clk_pll_get_characteristics(struct device_node *np)
        if (!characteristics)
                return NULL;
 
-       output = kzalloc(sizeof(*output) * num_output, GFP_KERNEL);
+       output = kcalloc(num_output, sizeof(*output), GFP_KERNEL);
        if (!output)
                goto out_free_characteristics;
 
        if (num_cells > 2) {
-               out = kzalloc(sizeof(*out) * num_output, GFP_KERNEL);
+               out = kcalloc(num_output, sizeof(*out), GFP_KERNEL);
                if (!out)
                        goto out_free_output;
        }
 
        if (num_cells > 3) {
-               icpll = kzalloc(sizeof(*icpll) * num_output, GFP_KERNEL);
+               icpll = kcalloc(num_output, sizeof(*icpll), GFP_KERNEL);
                if (!icpll)
                        goto out_free_output;
        }