hwmon: (nct6683) remove unused variable in nct6683_create_attr_group
authorZeng Heng <zengheng4@huawei.com>
Tue, 27 Sep 2022 11:43:52 +0000 (19:43 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 2 Oct 2022 15:01:18 +0000 (08:01 -0700)
When enable 'unused-but-set-variable' compile
warning option, it would raise warning as below:

drivers/hwmon/nct6683.c:415:9:
warning: variable 'j' set but not used [-Wunused-but-set-variable]

Variable 'j' in nct6683_create_attr_group is unused,
so remove it and simplify the 'for' loop.

Signed-off-by: Zeng Heng <zengheng4@huawei.com>
Link: https://lore.kernel.org/r/20220927114352.2498079-1-zengheng4@huawei.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/nct6683.c

index 6a9f420e7d32339e0f0fc578009a4c767a21e637..a872f783e9cc374ee9f40631260eef452ba5c3c9 100644 (file)
@@ -412,7 +412,7 @@ nct6683_create_attr_group(struct device *dev,
        struct sensor_device_attr_u *su;
        struct attribute_group *group;
        struct attribute **attrs;
-       int i, j, count;
+       int i, count;
 
        if (repeat <= 0)
                return ERR_PTR(-EINVAL);
@@ -443,7 +443,7 @@ nct6683_create_attr_group(struct device *dev,
 
        for (i = 0; i < repeat; i++) {
                t = tg->templates;
-               for (j = 0; *t != NULL; j++) {
+               while (*t) {
                        snprintf(su->name, sizeof(su->name),
                                 (*t)->dev_attr.attr.name, tg->base + i);
                        if ((*t)->s2) {