soc/tegra: pmc: Fix imbalanced clock disabling in error code path
authorDmitry Osipenko <digetx@gmail.com>
Tue, 2 Mar 2021 12:24:58 +0000 (15:24 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 13:04:33 +0000 (14:04 +0100)
commit 19221e3083020bd9537624caa0ee0145ed92ba36 upstream.

The tegra_powergate_power_up() has a typo in the error code path where it
will try to disable clocks twice, fix it. In practice that error never
happens, so this is a minor correction.

Tested-by: Peter Geis <pgwipeout@gmail.com> # Ouya T30
Tested-by: Nicolas Chauvet <kwizart@gmail.com> # PAZ00 T20 and TK1 T124
Tested-by: Matt Merhar <mattmerhar@protonmail.com> # Ouya T30
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/soc/tegra/pmc.c

index 857354a69c39d51f93f0b470fea9bc4f1cbf4150..5726c232e61d5b748bff834b16406bb609ef05e9 100644 (file)
@@ -693,7 +693,7 @@ static int tegra_powergate_power_up(struct tegra_powergate *pg,
 
        err = tegra_powergate_enable_clocks(pg);
        if (err)
-               goto disable_clks;
+               goto powergate_off;
 
        usleep_range(10, 20);