raid5-ppl: use swap() to make code cleaner
authorYang Guang <yang.guang5@zte.com.cn>
Thu, 28 Oct 2021 08:48:05 +0000 (08:48 +0000)
committerSong Liu <songliubraving@fb.com>
Tue, 2 Nov 2021 18:41:45 +0000 (11:41 -0700)
Use the macro `swap()` defined in `include/linux/minmax.h` to avoid
opencoding it.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
Signed-off-by: Song Liu <songliubraving@fb.com>
drivers/md/raid5-ppl.c

index 3ddc2aa..4ab4179 100644 (file)
@@ -1081,7 +1081,7 @@ static int ppl_load_distributed(struct ppl_log *log)
        struct ppl_conf *ppl_conf = log->ppl_conf;
        struct md_rdev *rdev = log->rdev;
        struct mddev *mddev = rdev->mddev;
-       struct page *page, *page2, *tmp;
+       struct page *page, *page2;
        struct ppl_header *pplhdr = NULL, *prev_pplhdr = NULL;
        u32 crc, crc_stored;
        u32 signature;
@@ -1156,9 +1156,7 @@ static int ppl_load_distributed(struct ppl_log *log)
                prev_pplhdr_offset = pplhdr_offset;
                prev_pplhdr = pplhdr;
 
-               tmp = page;
-               page = page2;
-               page2 = tmp;
+               swap(page, page2);
 
                /* calculate next potential ppl offset */
                for (i = 0; i < le32_to_cpu(pplhdr->entries_count); i++)