mhi: pci_generic: Print warning in case of firmware crash
authorLoic Poulain <loic.poulain@linaro.org>
Wed, 3 Feb 2021 16:39:42 +0000 (17:39 +0100)
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Fri, 5 Feb 2021 12:28:49 +0000 (17:58 +0530)
Print warning when MHI detects sys error.

Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/1612370382-21643-1-git-send-email-loic.poulain@linaro.org
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/bus/mhi/pci_generic.c

index 444693e..2476041 100644 (file)
@@ -217,7 +217,17 @@ static void mhi_pci_write_reg(struct mhi_controller *mhi_cntrl,
 static void mhi_pci_status_cb(struct mhi_controller *mhi_cntrl,
                              enum mhi_callback cb)
 {
+       struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev);
+
        /* Nothing to do for now */
+       switch (cb) {
+       case MHI_CB_FATAL_ERROR:
+       case MHI_CB_SYS_ERROR:
+               dev_warn(&pdev->dev, "firmware crashed (%u)\n", cb);
+               break;
+       default:
+               break;
+       }
 }
 
 static bool mhi_pci_is_alive(struct mhi_controller *mhi_cntrl)