spi: cadence-qspi: move cadence qspi macros to header file
authorT Karthik Reddy <t.karthik.reddy@xilinx.com>
Thu, 12 May 2022 10:05:31 +0000 (04:05 -0600)
committerMichal Simek <michal.simek@amd.com>
Wed, 29 Jun 2022 13:58:48 +0000 (15:58 +0200)
Move all the cadence macros from cadence_qspi_apb.c to cadence_qspi.h
file.

Signed-off-by: T Karthik Reddy <t.karthik.reddy@xilinx.com>
Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
Link: https://lore.kernel.org/r/20220512100535.16364-2-ashok.reddy.soma@xilinx.com
Signed-off-by: Michal Simek <michal.simek@amd.com>
drivers/spi/cadence_qspi.h
drivers/spi/cadence_qspi_apb.c

index a2b620a..4c21481 100644 (file)
@@ -8,6 +8,8 @@
 #define __CADENCE_QSPI_H__
 
 #include <reset.h>
+#include <linux/mtd/spi-nor.h>
+#include <spi-mem.h>
 
 #define CQSPI_IS_ADDR(cmd_len)         (cmd_len > 1 ? 1 : 0)
 
 #define CQSPI_DECODER_MAX_CS           16
 #define CQSPI_READ_CAPTURE_MAX_DELAY   16
 
+#define CQSPI_REG_POLL_US                       1 /* 1us */
+#define CQSPI_REG_RETRY                         10000
+#define CQSPI_POLL_IDLE_RETRY                   3
+
+/* Transfer mode */
+#define CQSPI_INST_TYPE_SINGLE                  0
+#define CQSPI_INST_TYPE_DUAL                    1
+#define CQSPI_INST_TYPE_QUAD                    2
+#define CQSPI_INST_TYPE_OCTAL                   3
+
+#define CQSPI_STIG_DATA_LEN_MAX                 8
+
+#define CQSPI_DUMMY_CLKS_PER_BYTE               8
+#define CQSPI_DUMMY_BYTES_MAX                   4
+#define CQSPI_DUMMY_CLKS_MAX                    31
+
+/****************************************************************************
+ * Controller's configuration and status register (offset from QSPI_BASE)
+ ****************************************************************************/
+#define CQSPI_REG_CONFIG                        0x00
+#define CQSPI_REG_CONFIG_ENABLE                 BIT(0)
+#define CQSPI_REG_CONFIG_CLK_POL                BIT(1)
+#define CQSPI_REG_CONFIG_CLK_PHA                BIT(2)
+#define CQSPI_REG_CONFIG_PHY_ENABLE_MASK        BIT(3)
+#define CQSPI_REG_CONFIG_DIRECT                 BIT(7)
+#define CQSPI_REG_CONFIG_DECODE                 BIT(9)
+#define CQSPI_REG_CONFIG_ENBL_DMA               BIT(15)
+#define CQSPI_REG_CONFIG_XIP_IMM                BIT(18)
+#define CQSPI_REG_CONFIG_DTR_PROT_EN_MASK       BIT(24)
+#define CQSPI_REG_CONFIG_CHIPSELECT_LSB         10
+#define CQSPI_REG_CONFIG_BAUD_LSB               19
+#define CQSPI_REG_CONFIG_DTR_PROTO             BIT(24)
+#define CQSPI_REG_CONFIG_DUAL_OPCODE           BIT(30)
+#define CQSPI_REG_CONFIG_IDLE_LSB               31
+#define CQSPI_REG_CONFIG_CHIPSELECT_MASK        0xF
+#define CQSPI_REG_CONFIG_BAUD_MASK              0xF
+
+#define CQSPI_REG_RD_INSTR                      0x04
+#define CQSPI_REG_RD_INSTR_OPCODE_LSB           0
+#define CQSPI_REG_RD_INSTR_TYPE_INSTR_LSB       8
+#define CQSPI_REG_RD_INSTR_TYPE_ADDR_LSB        12
+#define CQSPI_REG_RD_INSTR_TYPE_DATA_LSB        16
+#define CQSPI_REG_RD_INSTR_MODE_EN_LSB          20
+#define CQSPI_REG_RD_INSTR_DUMMY_LSB            24
+#define CQSPI_REG_RD_INSTR_TYPE_INSTR_MASK      0x3
+#define CQSPI_REG_RD_INSTR_TYPE_ADDR_MASK       0x3
+#define CQSPI_REG_RD_INSTR_TYPE_DATA_MASK       0x3
+#define CQSPI_REG_RD_INSTR_DUMMY_MASK           0x1F
+
+#define CQSPI_REG_WR_INSTR                      0x08
+#define CQSPI_REG_WR_INSTR_OPCODE_LSB           0
+#define CQSPI_REG_WR_INSTR_TYPE_ADDR_LSB       12
+#define CQSPI_REG_WR_INSTR_TYPE_DATA_LSB       16
+
+#define CQSPI_REG_DELAY                         0x0C
+#define CQSPI_REG_DELAY_TSLCH_LSB               0
+#define CQSPI_REG_DELAY_TCHSH_LSB               8
+#define CQSPI_REG_DELAY_TSD2D_LSB               16
+#define CQSPI_REG_DELAY_TSHSL_LSB               24
+#define CQSPI_REG_DELAY_TSLCH_MASK              0xFF
+#define CQSPI_REG_DELAY_TCHSH_MASK              0xFF
+#define CQSPI_REG_DELAY_TSD2D_MASK              0xFF
+#define CQSPI_REG_DELAY_TSHSL_MASK              0xFF
+
+#define CQSPI_REG_RD_DATA_CAPTURE               0x10
+#define CQSPI_REG_RD_DATA_CAPTURE_BYPASS        BIT(0)
+#define CQSPI_REG_READCAPTURE_DQS_ENABLE        BIT(8)
+#define CQSPI_REG_RD_DATA_CAPTURE_DELAY_LSB     1
+#define CQSPI_REG_RD_DATA_CAPTURE_DELAY_MASK    0xF
+
+#define CQSPI_REG_SIZE                          0x14
+#define CQSPI_REG_SIZE_ADDRESS_LSB              0
+#define CQSPI_REG_SIZE_PAGE_LSB                 4
+#define CQSPI_REG_SIZE_BLOCK_LSB                16
+#define CQSPI_REG_SIZE_ADDRESS_MASK             0xF
+#define CQSPI_REG_SIZE_PAGE_MASK                0xFFF
+#define CQSPI_REG_SIZE_BLOCK_MASK               0x3F
+
+#define CQSPI_REG_SRAMPARTITION                 0x18
+#define CQSPI_REG_INDIRECTTRIGGER               0x1C
+
+#define CQSPI_REG_REMAP                         0x24
+#define CQSPI_REG_MODE_BIT                      0x28
+
+#define CQSPI_REG_SDRAMLEVEL                    0x2C
+#define CQSPI_REG_SDRAMLEVEL_RD_LSB             0
+#define CQSPI_REG_SDRAMLEVEL_WR_LSB             16
+#define CQSPI_REG_SDRAMLEVEL_RD_MASK            0xFFFF
+#define CQSPI_REG_SDRAMLEVEL_WR_MASK            0xFFFF
+
+#define CQSPI_REG_WR_COMPLETION_CTRL           0x38
+#define CQSPI_REG_WR_DISABLE_AUTO_POLL         BIT(14)
+
+#define CQSPI_REG_IRQSTATUS                     0x40
+#define CQSPI_REG_IRQMASK                       0x44
+
+#define CQSPI_REG_INDIRECTRD                    0x60
+#define CQSPI_REG_INDIRECTRD_START              BIT(0)
+#define CQSPI_REG_INDIRECTRD_CANCEL             BIT(1)
+#define CQSPI_REG_INDIRECTRD_INPROGRESS         BIT(2)
+#define CQSPI_REG_INDIRECTRD_DONE               BIT(5)
+
+#define CQSPI_REG_INDIRECTRDWATERMARK           0x64
+#define CQSPI_REG_INDIRECTRDSTARTADDR           0x68
+#define CQSPI_REG_INDIRECTRDBYTES               0x6C
+
+#define CQSPI_REG_CMDCTRL                       0x90
+#define CQSPI_REG_CMDCTRL_EXECUTE               BIT(0)
+#define CQSPI_REG_CMDCTRL_INPROGRESS            BIT(1)
+#define CQSPI_REG_CMDCTRL_DUMMY_LSB             7
+#define CQSPI_REG_CMDCTRL_WR_BYTES_LSB          12
+#define CQSPI_REG_CMDCTRL_WR_EN_LSB             15
+#define CQSPI_REG_CMDCTRL_ADD_BYTES_LSB         16
+#define CQSPI_REG_CMDCTRL_ADDR_EN_LSB           19
+#define CQSPI_REG_CMDCTRL_RD_BYTES_LSB          20
+#define CQSPI_REG_CMDCTRL_RD_EN_LSB             23
+#define CQSPI_REG_CMDCTRL_OPCODE_LSB            24
+#define CQSPI_REG_CMDCTRL_DUMMY_MASK            0x1F
+#define CQSPI_REG_CMDCTRL_WR_BYTES_MASK         0x7
+#define CQSPI_REG_CMDCTRL_ADD_BYTES_MASK        0x3
+#define CQSPI_REG_CMDCTRL_RD_BYTES_MASK         0x7
+#define CQSPI_REG_CMDCTRL_OPCODE_MASK           0xFF
+
+#define CQSPI_REG_INDIRECTWR                    0x70
+#define CQSPI_REG_INDIRECTWR_START              BIT(0)
+#define CQSPI_REG_INDIRECTWR_CANCEL             BIT(1)
+#define CQSPI_REG_INDIRECTWR_INPROGRESS         BIT(2)
+#define CQSPI_REG_INDIRECTWR_DONE               BIT(5)
+
+#define CQSPI_REG_INDIRECTWRWATERMARK           0x74
+#define CQSPI_REG_INDIRECTWRSTARTADDR           0x78
+#define CQSPI_REG_INDIRECTWRBYTES               0x7C
+
+#define CQSPI_REG_CMDADDRESS                    0x94
+#define CQSPI_REG_CMDREADDATALOWER              0xA0
+#define CQSPI_REG_CMDREADDATAUPPER              0xA4
+#define CQSPI_REG_CMDWRITEDATALOWER             0xA8
+#define CQSPI_REG_CMDWRITEDATAUPPER             0xAC
+
+#define CQSPI_REG_OP_EXT_LOWER                  0xE0
+#define CQSPI_REG_OP_EXT_READ_LSB               24
+#define CQSPI_REG_OP_EXT_WRITE_LSB              16
+#define CQSPI_REG_OP_EXT_STIG_LSB               0
+
+#define CQSPI_REG_PHY_CONFIG                    0xB4
+#define CQSPI_REG_PHY_CONFIG_RESET_FLD_MASK     0x40000000
+
+#define CQSPI_DMA_DST_ADDR_REG                  0x1800
+#define CQSPI_DMA_DST_SIZE_REG                  0x1804
+#define CQSPI_DMA_DST_STS_REG                   0x1808
+#define CQSPI_DMA_DST_CTRL_REG                  0x180C
+#define CQSPI_DMA_DST_I_STS_REG                 0x1814
+#define CQSPI_DMA_DST_I_ENBL_REG                0x1818
+#define CQSPI_DMA_DST_I_DISBL_REG               0x181C
+#define CQSPI_DMA_DST_CTRL2_REG                 0x1824
+#define CQSPI_DMA_DST_ADDR_MSB_REG              0x1828
+
+#define CQSPI_DMA_SRC_RD_ADDR_REG               0x1000
+
+#define CQSPI_REG_DMA_PERIPH_CFG                0x20
+#define CQSPI_REG_INDIR_TRIG_ADDR_RANGE         0x80
+#define CQSPI_DFLT_INDIR_TRIG_ADDR_RANGE        6
+#define CQSPI_DFLT_DMA_PERIPH_CFG               0x602
+#define CQSPI_DFLT_DST_CTRL_REG_VAL             0xF43FFA00
+
+#define CQSPI_DMA_DST_I_STS_DONE                BIT(1)
+#define CQSPI_DMA_TIMEOUT                       10000000
+
+#define CQSPI_REG_IS_IDLE(base)                                \
+       ((readl((base) + CQSPI_REG_CONFIG) >>           \
+       CQSPI_REG_CONFIG_IDLE_LSB) & 0x1)
+
+#define CQSPI_GET_RD_SRAM_LEVEL(reg_base)              \
+       (((readl((reg_base) + CQSPI_REG_SDRAMLEVEL)) >> \
+       CQSPI_REG_SDRAMLEVEL_RD_LSB) & CQSPI_REG_SDRAMLEVEL_RD_MASK)
+
+#define CQSPI_GET_WR_SRAM_LEVEL(reg_base)              \
+       (((readl((reg_base) + CQSPI_REG_SDRAMLEVEL)) >> \
+       CQSPI_REG_SDRAMLEVEL_WR_LSB) & CQSPI_REG_SDRAMLEVEL_WR_MASK)
+
 struct cadence_spi_plat {
        unsigned int    ref_clk_hz;
        unsigned int    max_hz;
index 2cdf4c9..ac8b1be 100644 (file)
 #include <malloc.h>
 #include "cadence_qspi.h"
 
-#define CQSPI_REG_POLL_US                      1 /* 1us */
-#define CQSPI_REG_RETRY                                10000
-#define CQSPI_POLL_IDLE_RETRY                  3
-
-/* Transfer mode */
-#define CQSPI_INST_TYPE_SINGLE                 0
-#define CQSPI_INST_TYPE_DUAL                   1
-#define CQSPI_INST_TYPE_QUAD                   2
-#define CQSPI_INST_TYPE_OCTAL                  3
-
-#define CQSPI_STIG_DATA_LEN_MAX                        8
-
-#define CQSPI_DUMMY_CLKS_PER_BYTE              8
-#define CQSPI_DUMMY_CLKS_MAX                   31
-
-/****************************************************************************
- * Controller's configuration and status register (offset from QSPI_BASE)
- ****************************************************************************/
-#define        CQSPI_REG_CONFIG                        0x00
-#define        CQSPI_REG_CONFIG_ENABLE                 BIT(0)
-#define        CQSPI_REG_CONFIG_CLK_POL                BIT(1)
-#define        CQSPI_REG_CONFIG_CLK_PHA                BIT(2)
-#define        CQSPI_REG_CONFIG_DIRECT                 BIT(7)
-#define        CQSPI_REG_CONFIG_DECODE                 BIT(9)
-#define        CQSPI_REG_CONFIG_XIP_IMM                BIT(18)
-#define        CQSPI_REG_CONFIG_CHIPSELECT_LSB         10
-#define        CQSPI_REG_CONFIG_BAUD_LSB               19
-#define CQSPI_REG_CONFIG_DTR_PROTO             BIT(24)
-#define CQSPI_REG_CONFIG_DUAL_OPCODE           BIT(30)
-#define        CQSPI_REG_CONFIG_IDLE_LSB               31
-#define        CQSPI_REG_CONFIG_CHIPSELECT_MASK        0xF
-#define        CQSPI_REG_CONFIG_BAUD_MASK              0xF
-
-#define        CQSPI_REG_RD_INSTR                      0x04
-#define        CQSPI_REG_RD_INSTR_OPCODE_LSB           0
-#define        CQSPI_REG_RD_INSTR_TYPE_INSTR_LSB       8
-#define        CQSPI_REG_RD_INSTR_TYPE_ADDR_LSB        12
-#define        CQSPI_REG_RD_INSTR_TYPE_DATA_LSB        16
-#define        CQSPI_REG_RD_INSTR_MODE_EN_LSB          20
-#define        CQSPI_REG_RD_INSTR_DUMMY_LSB            24
-#define        CQSPI_REG_RD_INSTR_TYPE_INSTR_MASK      0x3
-#define        CQSPI_REG_RD_INSTR_TYPE_ADDR_MASK       0x3
-#define        CQSPI_REG_RD_INSTR_TYPE_DATA_MASK       0x3
-#define        CQSPI_REG_RD_INSTR_DUMMY_MASK           0x1F
-
-#define        CQSPI_REG_WR_INSTR                      0x08
-#define        CQSPI_REG_WR_INSTR_OPCODE_LSB           0
-#define CQSPI_REG_WR_INSTR_TYPE_ADDR_LSB       12
-#define        CQSPI_REG_WR_INSTR_TYPE_DATA_LSB        16
-
-#define        CQSPI_REG_DELAY                         0x0C
-#define        CQSPI_REG_DELAY_TSLCH_LSB               0
-#define        CQSPI_REG_DELAY_TCHSH_LSB               8
-#define        CQSPI_REG_DELAY_TSD2D_LSB               16
-#define        CQSPI_REG_DELAY_TSHSL_LSB               24
-#define        CQSPI_REG_DELAY_TSLCH_MASK              0xFF
-#define        CQSPI_REG_DELAY_TCHSH_MASK              0xFF
-#define        CQSPI_REG_DELAY_TSD2D_MASK              0xFF
-#define        CQSPI_REG_DELAY_TSHSL_MASK              0xFF
-
-#define        CQSPI_REG_RD_DATA_CAPTURE               0x10
-#define        CQSPI_REG_RD_DATA_CAPTURE_BYPASS        BIT(0)
-#define        CQSPI_REG_RD_DATA_CAPTURE_DELAY_LSB     1
-#define        CQSPI_REG_RD_DATA_CAPTURE_DELAY_MASK    0xF
-
-#define        CQSPI_REG_SIZE                          0x14
-#define        CQSPI_REG_SIZE_ADDRESS_LSB              0
-#define        CQSPI_REG_SIZE_PAGE_LSB                 4
-#define        CQSPI_REG_SIZE_BLOCK_LSB                16
-#define        CQSPI_REG_SIZE_ADDRESS_MASK             0xF
-#define        CQSPI_REG_SIZE_PAGE_MASK                0xFFF
-#define        CQSPI_REG_SIZE_BLOCK_MASK               0x3F
-
-#define        CQSPI_REG_SRAMPARTITION                 0x18
-#define        CQSPI_REG_INDIRECTTRIGGER               0x1C
-
-#define        CQSPI_REG_REMAP                         0x24
-#define        CQSPI_REG_MODE_BIT                      0x28
-
-#define        CQSPI_REG_SDRAMLEVEL                    0x2C
-#define        CQSPI_REG_SDRAMLEVEL_RD_LSB             0
-#define        CQSPI_REG_SDRAMLEVEL_WR_LSB             16
-#define        CQSPI_REG_SDRAMLEVEL_RD_MASK            0xFFFF
-#define        CQSPI_REG_SDRAMLEVEL_WR_MASK            0xFFFF
-
-#define CQSPI_REG_WR_COMPLETION_CTRL           0x38
-#define CQSPI_REG_WR_DISABLE_AUTO_POLL         BIT(14)
-
-#define        CQSPI_REG_IRQSTATUS                     0x40
-#define        CQSPI_REG_IRQMASK                       0x44
-
-#define        CQSPI_REG_INDIRECTRD                    0x60
-#define        CQSPI_REG_INDIRECTRD_START              BIT(0)
-#define        CQSPI_REG_INDIRECTRD_CANCEL             BIT(1)
-#define        CQSPI_REG_INDIRECTRD_INPROGRESS         BIT(2)
-#define        CQSPI_REG_INDIRECTRD_DONE               BIT(5)
-
-#define        CQSPI_REG_INDIRECTRDWATERMARK           0x64
-#define        CQSPI_REG_INDIRECTRDSTARTADDR           0x68
-#define        CQSPI_REG_INDIRECTRDBYTES               0x6C
-
-#define        CQSPI_REG_CMDCTRL                       0x90
-#define        CQSPI_REG_CMDCTRL_EXECUTE               BIT(0)
-#define        CQSPI_REG_CMDCTRL_INPROGRESS            BIT(1)
-#define        CQSPI_REG_CMDCTRL_DUMMY_LSB             7
-#define        CQSPI_REG_CMDCTRL_WR_BYTES_LSB          12
-#define        CQSPI_REG_CMDCTRL_WR_EN_LSB             15
-#define        CQSPI_REG_CMDCTRL_ADD_BYTES_LSB         16
-#define        CQSPI_REG_CMDCTRL_ADDR_EN_LSB           19
-#define        CQSPI_REG_CMDCTRL_RD_BYTES_LSB          20
-#define        CQSPI_REG_CMDCTRL_RD_EN_LSB             23
-#define        CQSPI_REG_CMDCTRL_OPCODE_LSB            24
-#define        CQSPI_REG_CMDCTRL_DUMMY_MASK            0x1F
-#define        CQSPI_REG_CMDCTRL_WR_BYTES_MASK         0x7
-#define        CQSPI_REG_CMDCTRL_ADD_BYTES_MASK        0x3
-#define        CQSPI_REG_CMDCTRL_RD_BYTES_MASK         0x7
-#define        CQSPI_REG_CMDCTRL_OPCODE_MASK           0xFF
-
-#define        CQSPI_REG_INDIRECTWR                    0x70
-#define        CQSPI_REG_INDIRECTWR_START              BIT(0)
-#define        CQSPI_REG_INDIRECTWR_CANCEL             BIT(1)
-#define        CQSPI_REG_INDIRECTWR_INPROGRESS         BIT(2)
-#define        CQSPI_REG_INDIRECTWR_DONE               BIT(5)
-
-#define        CQSPI_REG_INDIRECTWRWATERMARK           0x74
-#define        CQSPI_REG_INDIRECTWRSTARTADDR           0x78
-#define        CQSPI_REG_INDIRECTWRBYTES               0x7C
-
-#define        CQSPI_REG_CMDADDRESS                    0x94
-#define        CQSPI_REG_CMDREADDATALOWER              0xA0
-#define        CQSPI_REG_CMDREADDATAUPPER              0xA4
-#define        CQSPI_REG_CMDWRITEDATALOWER             0xA8
-#define        CQSPI_REG_CMDWRITEDATAUPPER             0xAC
-
-#define CQSPI_REG_OP_EXT_LOWER                 0xE0
-#define CQSPI_REG_OP_EXT_READ_LSB              24
-#define CQSPI_REG_OP_EXT_WRITE_LSB             16
-#define CQSPI_REG_OP_EXT_STIG_LSB              0
-
-#define CQSPI_REG_IS_IDLE(base)                                        \
-       ((readl(base + CQSPI_REG_CONFIG) >>             \
-               CQSPI_REG_CONFIG_IDLE_LSB) & 0x1)
-
-#define CQSPI_GET_RD_SRAM_LEVEL(reg_base)                      \
-       (((readl(reg_base + CQSPI_REG_SDRAMLEVEL)) >>   \
-       CQSPI_REG_SDRAMLEVEL_RD_LSB) & CQSPI_REG_SDRAMLEVEL_RD_MASK)
-
-#define CQSPI_GET_WR_SRAM_LEVEL(reg_base)                      \
-       (((readl(reg_base + CQSPI_REG_SDRAMLEVEL)) >>   \
-       CQSPI_REG_SDRAMLEVEL_WR_LSB) & CQSPI_REG_SDRAMLEVEL_WR_MASK)
-
 void cadence_qspi_apb_controller_enable(void *reg_base)
 {
        unsigned int reg;