[media] tm6000: Clean up file handle in open() error path
authorSantosh Kumar Singh <kumar.san1093@gmail.com>
Mon, 19 Dec 2016 17:10:58 +0000 (15:10 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 31 Jan 2017 09:45:24 +0000 (07:45 -0200)
Fix to avoid possible memory leak and exit file handle
in error paths.

Signed-off-by: Santosh Kumar Singh <kumar.san1093@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/tm6000/tm6000-video.c

index 3367a3b..c4fdc1f 100644 (file)
@@ -1371,8 +1371,11 @@ static int __tm6000_open(struct file *file)
 
        /* initialize hardware on analog mode */
        rc = tm6000_init_analog_mode(dev);
-       if (rc < 0)
+       if (rc < 0) {
+               v4l2_fh_exit(&fh->fh);
+               kfree(fh);
                return rc;
+       }
 
        dev->mode = TM6000_MODE_ANALOG;