ASoC: rt1308: clarify expression
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 2 Mar 2021 21:25:10 +0000 (15:25 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:09:59 +0000 (13:09 +0000)
cppcheck warning:

sound/soc/codecs/rt1308.c:676:40: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
  pll_code.k_code << RT1308_PLL1_K_SFT |
                                       ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210302212527.55158-8-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt1308.c

index 76e6584..b4e5546 100644 (file)
@@ -673,10 +673,10 @@ static int rt1308_set_component_pll(struct snd_soc_component *component,
                pll_code.n_code, pll_code.k_code);
 
        snd_soc_component_write(component, RT1308_PLL_1,
-               pll_code.k_code << RT1308_PLL1_K_SFT |
-               pll_code.m_bp << RT1308_PLL1_M_BYPASS_SFT |
-               (pll_code.m_bp ? 0 : pll_code.m_code) << RT1308_PLL1_M_SFT |
-               pll_code.n_code << RT1308_PLL1_N_SFT);
+               (pll_code.k_code << RT1308_PLL1_K_SFT) |
+               (pll_code.m_bp << RT1308_PLL1_M_BYPASS_SFT) |
+               ((pll_code.m_bp ? 0 : pll_code.m_code) << RT1308_PLL1_M_SFT) |
+               (pll_code.n_code << RT1308_PLL1_N_SFT));
 
        rt1308->pll_in = freq_in;
        rt1308->pll_out = freq_out;