pinctrl: samsung: Fix device node refcount leaks in S3C64xx wakeup controller init

commit 7f028caadf6c37580d0f59c6c094ed09afc04062 upstream.

In s3c64xx_eint_eint0_init() the for_each_child_of_node() loop is used
with a break to find a matching child node.  Although each iteration of
for_each_child_of_node puts the previous node, but early exit from loop
misses it.  This leads to leak of device node.

Cc: <stable@vger.kernel.org>
Fixes: 61dd72613177 ("pinctrl: Add pinctrl-s3c64xx driver")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/pinctrl/samsung/pinctrl-s3c64xx.c b/drivers/pinctrl/samsung/pinctrl-s3c64xx.c
index c399f09..f97f817 100644 (file)
--- a/drivers/pinctrl/samsung/pinctrl-s3c64xx.c
+++ b/drivers/pinctrl/samsung/pinctrl-s3c64xx.c
@@ -704,8 +704,10 @@ static int s3c64xx_eint_eint0_init(struct samsung_pinctrl_drv_data *d)
                return -ENODEV;
 
        data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
-       if (!data)
+       if (!data) {
+               of_node_put(eint0_np);
                return -ENOMEM;
+       }
        data->drvdata = d;
 
        for (i = 0; i < NUM_EINT0_IRQ; ++i) {
@@ -714,6 +716,7 @@ static int s3c64xx_eint_eint0_init(struct samsung_pinctrl_drv_data *d)
                irq = irq_of_parse_and_map(eint0_np, i);
                if (!irq) {
                        dev_err(dev, "failed to get wakeup EINT IRQ %d\n", i);
+                       of_node_put(eint0_np);
                        return -ENXIO;
                }
 
@@ -721,6 +724,7 @@ static int s3c64xx_eint_eint0_init(struct samsung_pinctrl_drv_data *d)
                                                 s3c64xx_eint0_handlers[i],
                                                 data);
        }
+       of_node_put(eint0_np);
 
        bank = d->pin_banks;
        for (i = 0; i < d->nr_banks; ++i, ++bank) {