i2c: Improve size determinations
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 2 Feb 2018 13:50:09 +0000 (14:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Aug 2023 08:23:49 +0000 (10:23 +0200)
[ Upstream commit 06e989578232da33a7fe96b04191b862af8b2cec ]

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding
size determination a bit safer according to the Linux coding style
convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Stable-dep-of: 05f933d5f731 ("i2c: nomadik: Remove a useless call in the remove function")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/i2c/busses/i2c-nomadik.c
drivers/i2c/busses/i2c-sh7760.c

index 05eaae5aeb18032538a2f072076124e1ea539206..5004b9dd98563bbbd51b438ce971f8a3fe32cff3 100644 (file)
@@ -970,7 +970,7 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
        struct i2c_vendor_data *vendor = id->data;
        u32 max_fifo_threshold = (vendor->fifodepth / 2) - 1;
 
-       dev = devm_kzalloc(&adev->dev, sizeof(struct nmk_i2c_dev), GFP_KERNEL);
+       dev = devm_kzalloc(&adev->dev, sizeof(*dev), GFP_KERNEL);
        if (!dev) {
                ret = -ENOMEM;
                goto err_no_mem;
index a0ccc5d009874d4d1a1d74e08ea0128c5fd63d4b..051b904cb35f6578b3a3d889b5aa8bc2f7e6fe26 100644 (file)
@@ -443,7 +443,7 @@ static int sh7760_i2c_probe(struct platform_device *pdev)
                goto out0;
        }
 
-       id = kzalloc(sizeof(struct cami2c), GFP_KERNEL);
+       id = kzalloc(sizeof(*id), GFP_KERNEL);
        if (!id) {
                ret = -ENOMEM;
                goto out0;