crypto: sun8i-ss - fix result memory leak on error path
authorCorentin Labbe <clabbe.montjoie@gmail.com>
Fri, 12 Feb 2021 08:46:10 +0000 (09:46 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sun, 7 Mar 2021 04:13:17 +0000 (15:13 +1100)
This patch fixes a memory leak on an error path.

Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c

index 11cbcbc..0b9aa24 100644 (file)
@@ -438,8 +438,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)
        kfree(pad);
 
        memcpy(areq->result, result, algt->alg.hash.halg.digestsize);
-       kfree(result);
 theend:
+       kfree(result);
        crypto_finalize_hash_request(engine, breq, err);
        return 0;
 }