Fix wrong type size

The data size of the Parcel is size_t. In 64-bit machine, the size of
the size_t is 8 bytes. This patch changes the size type to the size_t
from the interger.

Change-Id: I6a9ccd057e3e7c26607a9703b5c189074911a660
oigned-off-by: Hwankyu Jhun <h.jhun@samsung.com>

diff --git a/src/client/pkginfo_client.cc b/src/client/pkginfo_client.cc
index c595f280133afa806da462583b699126a5e16424..1ddf91174a0a0d5d853e5cfceba45e70a8ea28b8 100644 (file)
--- a/src/client/pkginfo_client.cc
+++ b/src/client/pkginfo_client.cc
@@ -138,7 +138,7 @@ PkgInfoClient::GetResultParcel() {
     return nullptr;
   }
 
-  int len = 0;
+  size_t len = 0;
   if (socket_->ReceiveData(&len, sizeof(len)) != 0 || len <= 0) {
     LOG(ERROR) << "Fail to receive data";
     return nullptr;

diff --git a/src/server/create_cache_request.cc b/src/server/create_cache_request.cc
index 0d49d0f8ab01986974f98485d86da96a5a849a19..f0b02cefb4efaae7c7381ee92960ff9dcb097914 100644 (file)
--- a/src/server/create_cache_request.cc
+++ b/src/server/create_cache_request.cc
@@ -25,7 +25,7 @@ const unsigned char* CreateCacheRequest::GetData() {
   return nullptr;
 }
 
-int CreateCacheRequest::GetSize() {
+size_t CreateCacheRequest::GetSize() {
   return 0;
 }
 

diff --git a/src/server/create_cache_request.hh b/src/server/create_cache_request.hh
index 18a03fe395d14746d669f23f7b004601e9596ffd..97e80e63bbf0a3036ba84c9664913e6abedfa6f4 100644 (file)
--- a/src/server/create_cache_request.hh
+++ b/src/server/create_cache_request.hh
@@ -39,7 +39,7 @@ class EXPORT_API CreateCacheRequest : public PkgRequest {
   CreateCacheRequest(uid_t uid, IEvent* listener)
       : uid_(uid), listener_(listener) {}
   const unsigned char* GetData() override;
-  int GetSize() override;
+  size_t GetSize() override;
   pid_t GetSenderPID() override;
   pid_t GetSenderTID() override;
   uid_t GetSenderUID() override;

diff --git a/src/server/pkg_request.cc b/src/server/pkg_request.cc
index 5de4a2867162f5694401267f4ab437385666bbe9..cb10e29853aaf8dad903f9a3ad6c4eaed8bab107 100644 (file)
--- a/src/server/pkg_request.cc
+++ b/src/server/pkg_request.cc
@@ -43,7 +43,7 @@ const unsigned char* PkgRequest::GetData() {
   return data_;
 }
 
-int PkgRequest::GetSize() {
+size_t PkgRequest::GetSize() {
   return data_size_;
 }
 

diff --git a/src/server/pkg_request.hh b/src/server/pkg_request.hh
index dcd2cfa69ce2cbe2ae34fd2e47110a098b75838d..29f81fc8c0756d193627ede50a9523cd8c53b1cc 100644 (file)
--- a/src/server/pkg_request.hh
+++ b/src/server/pkg_request.hh
@@ -42,7 +42,7 @@ class EXPORT_API PkgRequest {
   bool ReceiveData();
 
   virtual const unsigned char* GetData();
-  virtual int GetSize();
+  virtual size_t GetSize();
   virtual pid_t GetSenderPID();
   virtual pid_t GetSenderTID();
   virtual uid_t GetSenderUID();
@@ -56,7 +56,7 @@ class EXPORT_API PkgRequest {
   std::unique_ptr<pkgmgr_common::socket::DataSocket> socket_;
   unsigned char* data_ = nullptr;
   pkgmgr_common::ReqType request_type_;
-  int data_size_;
+  size_t data_size_;
   bool privilege_checked_;
   pid_t sender_tid_;
 };

diff --git a/src/server/request_handler/abstract_request_handler.hh b/src/server/request_handler/abstract_request_handler.hh
index 1a54cd65e1718347ce587a0c87a7e55a67e3599c..72cb5b5125a57e29227b338e1dba5bb0a1adf3a0 100644 (file)
--- a/src/server/request_handler/abstract_request_handler.hh
+++ b/src/server/request_handler/abstract_request_handler.hh
@@ -23,7 +23,7 @@ namespace request_handler {
 class EXPORT_API AbstractRequestHandler {
  public:
   virtual ~AbstractRequestHandler() = default;
-  virtual bool HandleRequest(unsigned char* data, int size,
+  virtual bool HandleRequest(unsigned char* data, size_t size,
       const std::string& locale) = 0;
 
   virtual tizen_base::Parcel ExtractResult();

diff --git a/src/server/request_handler/command_request_handler.cc b/src/server/request_handler/command_request_handler.cc
index 47426fa86505b1cbda82cdb9e9631d18f5796a0c..d98e4a4deb294016a5270436186a462553065af7 100644 (file)
--- a/src/server/request_handler/command_request_handler.cc
+++ b/src/server/request_handler/command_request_handler.cc
@@ -20,7 +20,7 @@ namespace pcp = pkgmgr_common::parcel;
 namespace pkgmgr_server {
 namespace request_handler {
 
-bool CommandRequestHandler::HandleRequest(unsigned char* data, int size,
+bool CommandRequestHandler::HandleRequest(unsigned char* data, size_t size,
     const std::string& locale) {
   auto abstract_parcel =
       pcp::ParcelableFactory::GetInst().CreateParcel(data, size);

diff --git a/src/server/request_handler/command_request_handler.hh b/src/server/request_handler/command_request_handler.hh
index a999aff7cb9bfec68dcf7a9851012d9f6543f93a..c04fd78caed26655500df2eec19a3e2285d9000e 100644 (file)
--- a/src/server/request_handler/command_request_handler.hh
+++ b/src/server/request_handler/command_request_handler.hh
@@ -20,7 +20,7 @@ namespace request_handler {
 
 class EXPORT_API CommandRequestHandler : public AbstractRequestHandler {
  public:
-  bool HandleRequest(unsigned char* data, int size,
+  bool HandleRequest(unsigned char* data, size_t size,
       const std::string& locale) override;
 };
 

diff --git a/src/server/request_handler/create_cache_request_handler.cc b/src/server/request_handler/create_cache_request_handler.cc
index 93bdf1abe8196914d1f80400996dddcaea8e609b..d65fa9551312f032e9cc98e0127a0a4b5229fd6e 100644 (file)
--- a/src/server/request_handler/create_cache_request_handler.cc
+++ b/src/server/request_handler/create_cache_request_handler.cc
@@ -64,7 +64,7 @@ int CreateCacheRequestHandler::Scheduler::Set(int priority) {
 CreateCacheRequestHandler::CreateCacheRequestHandler(): scheduler_(gettid()) {
 }
 
-bool CreateCacheRequestHandler::HandleRequest(unsigned char* data, int size,
+bool CreateCacheRequestHandler::HandleRequest(unsigned char* data, size_t size,
     const std::string& locale) {
   psd::CacheDBHandler db(GetUID(), GetPID());
   db.SetLocale(locale);

diff --git a/src/server/request_handler/create_cache_request_handler.hh b/src/server/request_handler/create_cache_request_handler.hh
index ad0ce178556db5563b042d12bdb45cb9e03f93d6..836fdf2d5f1b2328d8b47009ca46e3f368f6c052 100644 (file)
--- a/src/server/request_handler/create_cache_request_handler.hh
+++ b/src/server/request_handler/create_cache_request_handler.hh
@@ -20,7 +20,7 @@ namespace request_handler {
 class EXPORT_API CreateCacheRequestHandler : public AbstractRequestHandler {
  public:
   CreateCacheRequestHandler();
-  bool HandleRequest(unsigned char* data, int size,
+  bool HandleRequest(unsigned char* data, size_t size,
       const std::string& locale) override;
   tizen_base::Parcel ExtractResult() override;
 

diff --git a/src/server/request_handler/create_db_request_handler.cc b/src/server/request_handler/create_db_request_handler.cc
index 2c7da13871eb73693ee7da682e48318f2070ab1f..c6754e5dfaad43bb73d924cb123ad12a31d62ff8 100644 (file)
--- a/src/server/request_handler/create_db_request_handler.cc
+++ b/src/server/request_handler/create_db_request_handler.cc
@@ -22,7 +22,7 @@ namespace psd = pkgmgr_server::database;
 namespace pkgmgr_server {
 namespace request_handler {
 
-bool CreateDBRequestHandler::HandleRequest(unsigned char* data, int size,
+bool CreateDBRequestHandler::HandleRequest(unsigned char* data, size_t size,
     const std::string& locale) {
   auto abstract_parcel =
       pcp::ParcelableFactory::GetInst().CreateParcel(data, size);

diff --git a/src/server/request_handler/create_db_request_handler.hh b/src/server/request_handler/create_db_request_handler.hh
index 3057f3208ba80e8d0659f73b469d888ad941a42d..d79edb1a675ae1c870a5bd8b744fdba030bedc7f 100644 (file)
--- a/src/server/request_handler/create_db_request_handler.hh
+++ b/src/server/request_handler/create_db_request_handler.hh
@@ -19,7 +19,7 @@ namespace request_handler {
 
 class EXPORT_API CreateDBRequestHandler : public AbstractRequestHandler {
  public:
-  bool HandleRequest(unsigned char* data, int size,
+  bool HandleRequest(unsigned char* data, size_t size,
       const std::string& locale) override;
 };
 

diff --git a/src/server/request_handler/get_appinfo_request_handler.cc b/src/server/request_handler/get_appinfo_request_handler.cc
index 827c09c2bd2e390e49b3ce57501165209eb8ea8a..ce6a0b1154191160fa605986a86dd84d62665cf8 100644 (file)
--- a/src/server/request_handler/get_appinfo_request_handler.cc
+++ b/src/server/request_handler/get_appinfo_request_handler.cc
@@ -19,7 +19,7 @@ namespace pkgmgr_server {
 namespace request_handler {
 
 bool GetAppinfoRequestHandler::HandleRequest(unsigned char* data,
-    int size, const std::string& locale) {
+    size_t size, const std::string& locale) {
   auto abstract_parcel =
       pcp::ParcelableFactory::GetInst().CreateParcel(data, size);
 

diff --git a/src/server/request_handler/get_appinfo_request_handler.hh b/src/server/request_handler/get_appinfo_request_handler.hh
index cd58141c29443eaf90ee8776af34ac6679202270..57d4355471c427fc234fe4db7ce250d47761623a 100644 (file)
--- a/src/server/request_handler/get_appinfo_request_handler.hh
+++ b/src/server/request_handler/get_appinfo_request_handler.hh
@@ -19,7 +19,7 @@ namespace request_handler {
 
 class EXPORT_API GetAppinfoRequestHandler : public AbstractRequestHandler {
  public:
-  bool HandleRequest(unsigned char* data, int size,
+  bool HandleRequest(unsigned char* data, size_t size,
       const std::string &locale) override;
 };
 

diff --git a/src/server/request_handler/get_cert_request_handler.cc b/src/server/request_handler/get_cert_request_handler.cc
index 3574db939904ee3794397dc8c0820b6826671921..32aed1f1fa88f794d0ad8b1cf1104ca85fddfcbe 100644 (file)
--- a/src/server/request_handler/get_cert_request_handler.cc
+++ b/src/server/request_handler/get_cert_request_handler.cc
@@ -18,7 +18,7 @@ namespace psd = pkgmgr_server::database;
 namespace pkgmgr_server {
 namespace request_handler {
 
-bool GetCertRequestHandler::HandleRequest(unsigned char* data, int size,
+bool GetCertRequestHandler::HandleRequest(unsigned char* data, size_t size,
     const std::string& locale) {
   auto abstract_parcel =
       pcp::ParcelableFactory::GetInst().CreateParcel(data, size);

diff --git a/src/server/request_handler/get_cert_request_handler.hh b/src/server/request_handler/get_cert_request_handler.hh
index 011dc4272cc1bca52187c8eae9812c9448c84fad..e8909c265edaaa05f40d820059e13c00464f9458 100644 (file)
--- a/src/server/request_handler/get_cert_request_handler.hh
+++ b/src/server/request_handler/get_cert_request_handler.hh
@@ -19,7 +19,7 @@ namespace request_handler {
 
 class EXPORT_API GetCertRequestHandler : public AbstractRequestHandler {
  public:
-  bool HandleRequest(unsigned char* data, int size,
+  bool HandleRequest(unsigned char* data, size_t size,
       const std::string& locale) override;
 };
 

diff --git a/src/server/request_handler/get_depinfo_request_handler.cc b/src/server/request_handler/get_depinfo_request_handler.cc
index e2c6328902f84d4c8ac4f4120f61d1b281c73e4f..6aa2007fb8ebb47e3e0159e09069d9aa38ebfb38 100644 (file)
--- a/src/server/request_handler/get_depinfo_request_handler.cc
+++ b/src/server/request_handler/get_depinfo_request_handler.cc
@@ -19,7 +19,7 @@ namespace psd = pkgmgr_server::database;
 namespace pkgmgr_server {
 namespace request_handler {
 
-bool GetDepinfoRequestHandler::HandleRequest(unsigned char* data, int size,
+bool GetDepinfoRequestHandler::HandleRequest(unsigned char* data, size_t size,
     const std::string& locale) {
   auto abstract_parcel =
       pcp::ParcelableFactory::GetInst().CreateParcel(data, size);

diff --git a/src/server/request_handler/get_depinfo_request_handler.hh b/src/server/request_handler/get_depinfo_request_handler.hh
index bae717926d92a78af7688b3eba8284a8c4c064f8..3bce7e84e7fa9b9994aaec80493c8bb92c7627b6 100644 (file)
--- a/src/server/request_handler/get_depinfo_request_handler.hh
+++ b/src/server/request_handler/get_depinfo_request_handler.hh
@@ -19,7 +19,7 @@ namespace request_handler {
 
 class EXPORT_API GetDepinfoRequestHandler : public AbstractRequestHandler {
  public:
-  bool HandleRequest(unsigned char* data, int size,
+  bool HandleRequest(unsigned char* data, size_t size,
       const std::string& locale) override;
 
 };

diff --git a/src/server/request_handler/get_pkginfo_request_handler.cc b/src/server/request_handler/get_pkginfo_request_handler.cc
index 11884fe8f7c4d865123a8881d355785399519092..5a92de4b84e93c20ba162261d26bf0ed0f72e2a4 100644 (file)
--- a/src/server/request_handler/get_pkginfo_request_handler.cc
+++ b/src/server/request_handler/get_pkginfo_request_handler.cc
@@ -20,7 +20,7 @@ namespace pkgmgr_server {
 namespace request_handler {
 
 bool GetPkginfoRequestHandler::HandleRequest(unsigned char* data,
-    int size, const std::string& locale) {
+    size_t size, const std::string& locale) {
   auto abstract_parcel =
       pcp::ParcelableFactory::GetInst().CreateParcel(data, size);
 

diff --git a/src/server/request_handler/get_pkginfo_request_handler.hh b/src/server/request_handler/get_pkginfo_request_handler.hh
index f163a89b0c7e317b844626ab5707315e57ebae07..a041b3dbb190258fd0013b5db4f8223d2de4cf14 100644 (file)
--- a/src/server/request_handler/get_pkginfo_request_handler.hh
+++ b/src/server/request_handler/get_pkginfo_request_handler.hh
@@ -19,7 +19,7 @@ namespace request_handler {
 
 class EXPORT_API GetPkginfoRequestHandler : public AbstractRequestHandler {
  public:
-  bool HandleRequest(unsigned char* data, int size,
+  bool HandleRequest(unsigned char* data, size_t size,
       const std::string& locale) override;
 };
 

diff --git a/src/server/request_handler/query_request_handler.cc b/src/server/request_handler/query_request_handler.cc
index 2ccdffa118ee381874e699ac6328af107d45d4dc..6eb5a28602093d08969a41a52250a4ee57e98ff2 100644 (file)
--- a/src/server/request_handler/query_request_handler.cc
+++ b/src/server/request_handler/query_request_handler.cc
@@ -19,7 +19,7 @@ namespace psd = pkgmgr_server::database;
 namespace pkgmgr_server {
 namespace request_handler {
 
-bool QueryRequestHandler::HandleRequest(unsigned char* data, int size,
+bool QueryRequestHandler::HandleRequest(unsigned char* data, size_t size,
                                         const std::string& locale) {
   auto abstract_parcel =
       pcp::ParcelableFactory::GetInst().CreateParcel(data, size);

diff --git a/src/server/request_handler/query_request_handler.hh b/src/server/request_handler/query_request_handler.hh
index e96e23542b761cb41ce39bba9457a8338c418f3d..3bb1639b9369dce1fda6777a18b9b6e1a52c25f0 100644 (file)
--- a/src/server/request_handler/query_request_handler.hh
+++ b/src/server/request_handler/query_request_handler.hh
@@ -20,7 +20,7 @@ namespace request_handler {
 
 class EXPORT_API QueryRequestHandler : public AbstractRequestHandler {
  public:
-  bool HandleRequest(unsigned char* data, int size,
+  bool HandleRequest(unsigned char* data, size_t size,
       const std::string& locale) override;
 
 };

diff --git a/src/server/request_handler/set_cert_request_handler.cc b/src/server/request_handler/set_cert_request_handler.cc
index 2852cca046cab9071d6f02839b721c684c958c67..47199f1a4c3c73cefe4adb1accfc96c1c631e5e9 100644 (file)
--- a/src/server/request_handler/set_cert_request_handler.cc
+++ b/src/server/request_handler/set_cert_request_handler.cc
@@ -19,7 +19,7 @@ namespace psd = pkgmgr_server::database;
 namespace pkgmgr_server {
 namespace request_handler {
 
-bool SetCertRequestHandler::HandleRequest(unsigned char* data, int size,
+bool SetCertRequestHandler::HandleRequest(unsigned char* data, size_t size,
     const std::string& locale) {
   auto abstract_parcel =
       pcp::ParcelableFactory::GetInst().CreateParcel(data, size);

diff --git a/src/server/request_handler/set_cert_request_handler.hh b/src/server/request_handler/set_cert_request_handler.hh
index 6e6a4ba8aae9d399f4ef0da67e53e4cb6ecb5314..10df48d74def130da947ceb8bde06c13a5db8967 100644 (file)
--- a/src/server/request_handler/set_cert_request_handler.hh
+++ b/src/server/request_handler/set_cert_request_handler.hh
@@ -21,7 +21,7 @@ class EXPORT_API SetCertRequestHandler : public AbstractRequestHandler {
  public:
   SetCertRequestHandler(bool is_offline = false) :
       AbstractRequestHandler(), is_offline_(is_offline) {}
-  bool HandleRequest(unsigned char* data, int size,
+  bool HandleRequest(unsigned char* data, size_t size,
       const std::string& locale) override;
 
  private:

diff --git a/src/server/request_handler/set_pkginfo_request_handler.cc b/src/server/request_handler/set_pkginfo_request_handler.cc
index 24093bac56af716b8e8eb96fffcc57e91e86ff24..0387f78c7d3569a62cf5a3dae6339992b0030aad 100644 (file)
--- a/src/server/request_handler/set_pkginfo_request_handler.cc
+++ b/src/server/request_handler/set_pkginfo_request_handler.cc
@@ -22,7 +22,7 @@ namespace pkgmgr_server {
 namespace request_handler {
 
 bool SetPkginfoRequestHandler::HandleRequest(unsigned char* data,
-    int size, const std::string& locale) {
+    size_t size, const std::string& locale) {
   auto abstract_parcel =
       pcp::ParcelableFactory::GetInst().CreateParcel(data, size);
 

diff --git a/src/server/request_handler/set_pkginfo_request_handler.hh b/src/server/request_handler/set_pkginfo_request_handler.hh
index 0c4821cdeecc3d8b7f96ce7094c40e79d10341c8..c3402467ea9e23cd84784fea74f8956f57e8af40 100644 (file)
--- a/src/server/request_handler/set_pkginfo_request_handler.hh
+++ b/src/server/request_handler/set_pkginfo_request_handler.hh
@@ -21,7 +21,7 @@ class EXPORT_API SetPkginfoRequestHandler : public AbstractRequestHandler {
  public:
   SetPkginfoRequestHandler(bool is_offline = false) :
       AbstractRequestHandler(), is_offline_(is_offline) {}
-  bool HandleRequest(unsigned char* data, int size,
+  bool HandleRequest(unsigned char* data, size_t size,
       const std::string& locale) override;
 
  private: