ice: Remove managed memory usage in ice_get_fw_log_cfg()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 11 Jun 2023 20:44:13 +0000 (22:44 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 22 Jun 2023 18:14:24 +0000 (11:14 -0700)
There is no need to use managed memory allocation here. The memory is
released at the end of the function.

Use kzalloc()/kfree() to simplify the code.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_common.c

index 6acb40f..e16d4c8 100644 (file)
@@ -833,7 +833,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
        u16 size;
 
        size = sizeof(*config) * ICE_AQC_FW_LOG_ID_MAX;
-       config = devm_kzalloc(ice_hw_to_dev(hw), size, GFP_KERNEL);
+       config = kzalloc(size, GFP_KERNEL);
        if (!config)
                return -ENOMEM;
 
@@ -856,7 +856,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
                }
        }
 
-       devm_kfree(ice_hw_to_dev(hw), config);
+       kfree(config);
 
        return status;
 }