Fix derefence after null check

Passing null pointer candidate_iter to g_variant_iter_loop, which dereference it.

Change-Id: I1dd821cb2a63c150b29de9b40392c6b0824d1da2
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>

diff --git a/capi/src/cscl-ui-dbus.cpp b/capi/src/cscl-ui-dbus.cpp
index 963f861..f0240d5 100644 (file)
--- a/capi/src/cscl-ui-dbus.cpp
+++ b/capi/src/cscl-ui-dbus.cpp
@@ -370,8 +370,10 @@ static void _handle_update_lookup_table(GVariant *parameters)
     int cursor_pos;
 
     g_variant_get(parameters, "(a(a(v))a(v)ii)", &attr_iter, &candidate_iter, &page_size, &cursor_pos);
-    if (!attr_iter || !candidate_iter)
+    if (!attr_iter || !candidate_iter) {
         LOGE("Failed to get variant");
+        return;
+    }
 
     lookup_table.set_page_size(page_size);
     lookup_table.set_cursor_pos(cursor_pos);