nfp: fix TLV offset calculation
authorEdwin Peer <edwin.peer@netronome.com>
Fri, 2 Feb 2018 03:41:43 +0000 (19:41 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 3 Feb 2018 00:08:20 +0000 (19:08 -0500)
The data pointer in the config space TLV parser already includes
NFP_NET_CFG_TLV_BASE, it should not be added again. Incorrect
offset values were only used in printed user output, rendering
the bug merely cosmetic.

Fixes: 73a0329b057e ("nfp: add TLV capabilities to the BAR")
Signed-off-by: Edwin Peer <edwin.peer@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c

index ffb4027..1f9149b 100644 (file)
@@ -65,7 +65,7 @@ int nfp_net_tlv_caps_parse(struct device *dev, u8 __iomem *ctrl_mem,
                u32 hdr = readl(data);
 
                length = FIELD_GET(NFP_NET_CFG_TLV_HEADER_LENGTH, hdr);
-               offset = data - ctrl_mem + NFP_NET_CFG_TLV_BASE;
+               offset = data - ctrl_mem;
 
                /* Advance past the header */
                data += 4;