fix coverity issues

- A pointer to freed memory is dereferenced.
- Use of an uninitialized variable.

Change-Id: I9287c00aa1417547d57d89e957c36326c4f428d5
Signed-off-by: wansuyoo <wansu.yoo@samsung.com>

diff --git a/src/dzl_dockerctl.c b/src/dzl_dockerctl.c
index 2faa9d4..5318b03 100755 (executable)
--- a/src/dzl_dockerctl.c
+++ b/src/dzl_dockerctl.c
@@ -752,6 +752,7 @@ static char *__generate_dockerd_env(void)
                        cmd_len += strlen(http_proxy);
                }
                free(ret_str);
+               ret_str = NULL;
        }
        ret = __CLI_command(GET_HTTPS_PROXY_CMD, 1, &ret_str);
        if (ret_str != NULL) {
@@ -760,6 +761,7 @@ static char *__generate_dockerd_env(void)
                        cmd_len += strlen(https_proxy);
                }
                free(ret_str);
+               ret_str = NULL;
        }
 
        if (cmd_len > 0) {

diff --git a/src/lib/ipc_client.c b/src/lib/ipc_client.c
index 230d8b2..75027a5 100755 (executable)
--- a/src/lib/ipc_client.c
+++ b/src/lib/ipc_client.c
@@ -34,7 +34,6 @@ static int __client_open_connection(char *server, SOCKET_HANDLE* phndl)
        printf("<<Client>> __client_open_connection\n");
        ret = IPC_OpenClientConnection(server, phndl);
        if (0 == ret)   {
-               printf("<<Client>> phndl->server_h = %d\n", phndl->server_h);
                printf("<<Client>> phndl->client_h = %d\n", phndl->client_h);
        }       else {
                printf("<<Client>> connection_init ERROR(%d) !!! {%s}\n", ret, SERVER);

diff --git a/src/lib/yaml_util.c b/src/lib/yaml_util.c
index 06df9a9..e6797c5 100644 (file)
--- a/src/lib/yaml_util.c
+++ b/src/lib/yaml_util.c
@@ -25,7 +25,7 @@ int yaml_getContents(char *file_name, char *contentsKey, char **retVal)
        int             stateYAML = YAML_NO_TOKEN;
        char    *scalarTokenVal = NULL;
        int             scalarTokenLen = 0;
-       char    keyTokenVal[256];
+       char    keyTokenVal[256] = {0, };
        char    retTmp[256];
        int             retTmpLen;
        int             blockSequenceCnt = 0;