inline.h: Avoid redundant ckWARN call
authorFather Chrysostomos <sprout@cpan.org>
Thu, 29 Aug 2013 06:12:07 +0000 (23:12 -0700)
committerFather Chrysostomos <sprout@cpan.org>
Thu, 29 Aug 2013 06:12:07 +0000 (23:12 -0700)
ckWARN calls Perl_ckwarn.  So does Perl_ck_warner.  So there is no
need to use both.

inline.h

index 86deaf5..066edf1 100644 (file)
--- a/inline.h
+++ b/inline.h
@@ -250,11 +250,9 @@ S_is_safe_syscall(pTHX_ SV *pv, const char *what, const char *op_name) {
         char *null_at;
         if (UNLIKELY((null_at = (char *)memchr(p, 0, SvCUR(pv)-1)) != NULL)) {
                 SETERRNO(ENOENT, LIB_INVARG);
-                if (ckWARN(WARN_SYSCALLS)) {
-                    Perl_ck_warner(aTHX_ packWARN(WARN_SYSCALLS),
+                Perl_ck_warner(aTHX_ packWARN(WARN_SYSCALLS),
                                    "Invalid \\0 character in %s for %s: %s\\0%s",
                                    what, op_name, p, null_at+1);
-                }
                 return FALSE;
         }
     }