compositor: simplify weston_surface_damage_rectangle()
authorPekka Paalanen <ppaalanen@gmail.com>
Thu, 9 Feb 2012 13:27:45 +0000 (15:27 +0200)
committerPekka Paalanen <ppaalanen@gmail.com>
Fri, 10 Feb 2012 13:47:56 +0000 (15:47 +0200)
The non-transformed case looked a little odd, calling
weston_surface_to_global(), since it already tests for transform.enabled
and simply uses width, height for the box.

Streamline it, by open-coding weston_surface_to_global(), and avoiding
another call into weston_surface_update_transform(). This way it does
not look suspicious to me.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
src/compositor.c

index 0c62fb0..486bd22 100644 (file)
@@ -437,10 +437,10 @@ weston_surface_damage_rectangle(struct weston_surface *surface,
                                      &box);
                pixman_region32_fini(&box);
        } else {
-               int32_t x, y;
-               weston_surface_to_global(surface, sx, sy, &x, &y);
                pixman_region32_union_rect(&surface->damage, &surface->damage,
-                                          x, y, width, height);
+                                          surface->geometry.x + sx,
+                                          surface->geometry.y + sy,
+                                          width, height);
        }
 
        weston_compositor_schedule_repaint(surface->compositor);