net/mlx5e: Default to Striding RQ when not conflicting with CQE compression
authorTariq Toukan <tariqt@nvidia.com>
Tue, 11 Jan 2022 16:28:12 +0000 (18:28 +0200)
committerSaeed Mahameed <saeedm@nvidia.com>
Thu, 17 Feb 2022 07:55:14 +0000 (23:55 -0800)
CQE compression is turned on by default on slow pci systems to help
reduce the load on pci.
In this case, Striding RQ was turned off as CQEs of packets that span
several strides were not compressed, significantly reducing the compression
effectiveness.
This issue does not exist when using the newer mini_cqe format "stride_index".
Hence, allow defaulting to Striding RQ in this case.

Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Gal Pressman <gal@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en/params.c

index d41936d..2d9707c 100644 (file)
@@ -359,12 +359,13 @@ void mlx5e_build_rq_params(struct mlx5_core_dev *mdev,
 {
        /* Prefer Striding RQ, unless any of the following holds:
         * - Striding RQ configuration is not possible/supported.
-        * - Slow PCI heuristic.
+        * - CQE compression is ON, and stride_index mini_cqe layout is not supported.
         * - Legacy RQ would use linear SKB while Striding RQ would use non-linear.
         *
         * No XSK params: checking the availability of striding RQ in general.
         */
-       if (!slow_pci_heuristic(mdev) &&
+       if ((!MLX5E_GET_PFLAG(params, MLX5E_PFLAG_RX_CQE_COMPRESS) ||
+            MLX5_CAP_GEN(mdev, mini_cqe_resp_stride_index)) &&
            mlx5e_striding_rq_possible(mdev, params) &&
            (mlx5e_rx_mpwqe_is_linear_skb(mdev, params, NULL) ||
             !mlx5e_rx_is_linear_skb(params, NULL)))