kernel.bbclass: fix hardlink test
authorBruce Ashfield <bruce.ashfield@windriver.com>
Sat, 16 Nov 2013 06:17:24 +0000 (01:17 -0500)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 16 Nov 2013 10:04:26 +0000 (10:04 +0000)
The commit [kernel.bbclass: test for hardlinks before installing] doesn't
work on all build machines without a space between the ! and the test for
hardlink equivalance. The build continues, while the test fails and no
copy is made into the sysroot. Eventually tasks like build_hdimg will fail
with the missing kernel with the root cause being less than obvious.

(From OE-Core rev: 0704648e9dfd2897f6f54773a0e7d2762117970c)

Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/kernel.bbclass

index 624b151..6959aa1 100644 (file)
@@ -248,7 +248,7 @@ kernel_do_install() {
        # Test to ensure that the output file and image type are not actually
        # the same file. If hardlinking is used, they will be the same, and there's
        # no need to install.
-       ![ ${KERNEL_OUTPUT} -ef $kerneldir/${KERNEL_IMAGETYPE} ] && install -m 0644 ${KERNEL_OUTPUT} $kerneldir/${KERNEL_IMAGETYPE}
+       ! [ ${KERNEL_OUTPUT} -ef $kerneldir/${KERNEL_IMAGETYPE} ] && install -m 0644 ${KERNEL_OUTPUT} $kerneldir/${KERNEL_IMAGETYPE}
        install -m 0644 System.map $kerneldir/System.map-${KERNEL_VERSION}
 
        # Dummy Makefile so the clean below works