nvme: loop: clear NVME_CTRL_ADMIN_Q_STOPPED after admin queue is reallocated
authorMing Lei <ming.lei@redhat.com>
Thu, 14 Oct 2021 08:17:09 +0000 (16:17 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 20 Oct 2021 00:27:58 +0000 (18:27 -0600)
The nvme-loop's admin queue may be freed and reallocated, and we have to
reset the flag of NVME_CTRL_ADMIN_Q_STOPPED so that the flag can match
with the quiesce state of the admin queue.

nvme-loop is the only driver to reallocate request queue, and not see
such usage in other nvme drivers.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20211014081710.1871747-6-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/target/loop.c

index 440e154..eb10942 100644 (file)
@@ -384,6 +384,8 @@ static int nvme_loop_configure_admin_queue(struct nvme_loop_ctrl *ctrl)
                error = PTR_ERR(ctrl->ctrl.admin_q);
                goto out_cleanup_fabrics_q;
        }
+       /* reset stopped state for the fresh admin queue */
+       clear_bit(NVME_CTRL_ADMIN_Q_STOPPED, &ctrl->ctrl.flags);
 
        error = nvmf_connect_admin_queue(&ctrl->ctrl);
        if (error)