libs/gst/base/gstbasetransform.c: always_in_place does not mean that the sink and...

Original commit message from CVS:
* libs/gst/base/gstbasetransform.c:
(gst_base_transform_buffer_alloc):
always_in_place does not mean that the sink and source caps are the
same! Make sure we don't blindly proxy the buffer_alloc in this case.

diff --git a/ChangeLog b/ChangeLog
index 2bf84a5..4b612d9 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2007-05-03  Wim Taymans  <wim@fluendo.com>
 
+       * libs/gst/base/gstbasetransform.c:
+       (gst_base_transform_buffer_alloc):
+       always_in_place does not mean that the sink and source caps are the
+       same! Make sure we don't blindly proxy the buffer_alloc in this case.
+
+2007-05-03  Wim Taymans  <wim@fluendo.com>
+
        * docs/libs/gstreamer-libs-sections.txt:
        * libs/gst/base/gstbasesrc.c: (gst_base_src_query_latency),
        (gst_base_src_default_query), (gst_base_src_get_range):

diff --git a/libs/gst/base/gstbasetransform.c b/libs/gst/base/gstbasetransform.c
index f2c10e5..525a9c3 100644 (file)
--- a/libs/gst/base/gstbasetransform.c
+++ b/libs/gst/base/gstbasetransform.c
@@ -1189,7 +1189,7 @@ not_configured:
     /* let the default allocator handle it... */
     GST_DEBUG_OBJECT (trans, "not configured");
     gst_buffer_replace (buf, NULL);
-    if (trans->passthrough || trans->always_in_place) {
+    if (trans->passthrough) {
       /* ...by calling alloc_buffer without setting caps on the src pad, which
        * will force negotiation in the chain function. */
       res = gst_pad_alloc_buffer (trans->srcpad, offset, size, caps, buf);
@@ -1204,7 +1204,7 @@ unknown_size:
     /* let the default allocator handle it... */
     GST_DEBUG_OBJECT (trans, "unknown size");
     gst_buffer_replace (buf, NULL);
-    if (trans->passthrough || trans->always_in_place) {
+    if (trans->passthrough) {
       /* ...by calling alloc_buffer without setting caps on the src pad, which
        * will force negotiation in the chain function. */
       res = gst_pad_alloc_buffer (trans->srcpad, offset, size, caps, buf);