staging: r8188eu: remove write-only variable cpwm
authorMartin Kaiser <martin@kaiser.cx>
Sat, 11 Sep 2021 14:15:12 +0000 (16:15 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Sep 2021 16:19:12 +0000 (18:19 +0200)
cpwm in struct pwrctrl_priv is never read. Remove it.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210911141521.24901-4-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_pwrctrl.c
drivers/staging/r8188eu/include/rtw_pwrctrl.h

index daae91f..2a0ee3a 100644 (file)
@@ -204,8 +204,6 @@ void rtw_set_rpwm(struct adapter *padapter, u8 pslv)
 
        if ((padapter->bSurpriseRemoved) ||
            (!padapter->hw_init_completed)) {
-               pwrpriv->cpwm = PS_STATE_S4;
-
                return;
        }
 
@@ -217,8 +215,6 @@ void rtw_set_rpwm(struct adapter *padapter, u8 pslv)
        pwrpriv->rpwm = pslv;
 
        pwrpriv->tog += 0x80;
-       pwrpriv->cpwm = pslv;
-
 }
 
 static u8 PS_RDY_CHECK(struct adapter *padapter)
@@ -423,7 +419,6 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter)
        pwrctrlpriv->bFwCurrentInPSMode = false;
 
        pwrctrlpriv->rpwm = 0;
-       pwrctrlpriv->cpwm = PS_STATE_S4;
 
        pwrctrlpriv->pwr_mode = PS_MODE_ACTIVE;
        pwrctrlpriv->smart_ps = padapter->registrypriv.smart_ps;
index 6a0efb0..c5804a4 100644 (file)
@@ -152,8 +152,6 @@ enum { /*  for ips_mode */
 struct pwrctrl_priv {
        struct semaphore lock;
        volatile u8 rpwm; /*  requested power state for fw */
-       volatile u8 cpwm; /*  fw current power state. updated when
-                          * 1. read from HCPWM 2. driver lowers power level */
        volatile u8 tog; /*  toggling */
        volatile u8 cpwm_tog; /*  toggling */