crash-manager: don't store in zip archive files referred by symlinks

minicoredump (will be introduced in next commit) has an option to save
/proc/<pid>/ files in report. As /proc/<pid>/fd/* contains symlinks, the
created archive will contain the contents of these fds. This is
undesirable as files might be quite big and contain private (sensitive)
data.

This commit adds -y option to zip, which will allow storing symlinks to
actual files instead of their contents (as it was available originally
under /proc/<pid>/)"

Change-Id: I0a7c9211eab1acd39da7db3930e967ddab5eceef

diff --git a/src/crash-manager/crash-manager.c b/src/crash-manager/crash-manager.c
index 4a5a44a..28d9cd0 100644 (file)
--- a/src/crash-manager/crash-manager.c
+++ b/src/crash-manager/crash-manager.c
@@ -762,7 +762,7 @@ static void compress(void)
                return;
        }
 
-       ret = snprintf(command, sizeof(command), "cd %s && /bin/zip -r %s %s > /dev/null 2>&1",
+       ret = snprintf(command, sizeof(command), "cd %s && /bin/zip -y -r %s %s > /dev/null 2>&1",
                        crash_info.temp_dir, zip_path, crash_info.name);
        if (ret < 0) {
                _E("Failed to snprintf for zip command");