fs.writeFile accepts Buffers

diff --git a/lib/fs.js b/lib/fs.js
index dde6ac6..efc7ab1 100644 (file)
--- a/lib/fs.js
+++ b/lib/fs.js
@@ -384,7 +384,7 @@ fs.writeFile = function (path, data, encoding_, callback) {
     if (openErr) {
       if (callback) callback(openErr);
     } else {
-      var buffer = new Buffer(data, encoding);
+      var buffer = data instanceof Buffer ? data : new Buffer(data, encoding);
       writeAll(fd, buffer, callback);
     }
   });

diff --git a/test/simple/test-fs-write-file.js b/test/simple/test-fs-write-file.js
index cc0fdfa..32ae961 100644 (file)
--- a/test/simple/test-fs-write-file.js
+++ b/test/simple/test-fs-write-file.js
@@ -26,9 +26,30 @@ fs.writeFile(filename, s, function (e) {
   });
 });
 
+// test that writeFile accepts buffers
+filename2 = join(fixturesDir, 'test2.txt');
+buf = new Buffer(s, 'utf8');
+error('writing to ' + filename2);
+
+fs.writeFile(filename2, s, function (e) {
+  if (e) throw e;
+
+  ncallbacks++;
+  error('file2 written');
+
+  fs.readFile(filename2, function (e, buffer) {
+    if (e) throw e;
+    error('file2 read');
+    ncallbacks++;
+    assert.equal(buf.length, buffer.length);
+  });
+});
+
 
 process.addListener('exit', function () {
   error('done');
+  assert.equal(4, ncallbacks);
 
-  assert.equal(2, ncallbacks);
-});
\ No newline at end of file
+  fs.unlinkSync(filename);
+  fs.unlinkSync(filename2);
+});